Implemented perspective view occlusion #52
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jun Tian <find_my_way@foxmail.com>
Co-authored-by: Jun Tian <find_my_way@foxmail.com>
Co-authored-by: Jun Tian <find_my_way@foxmail.com>
This reverts commit 1b3efdc.
bringing up to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements perspective occlusion as described in #30. To turn occlusion on or off, assign the kwarg
perspective::Boolofget_agent_viewtotrueorfalse.This branch does not currently work, as environments without an
objectsattribute currently throw an error, and I'm at a loss for an elegant workaround. I'm also skeptical that it functions as desired, but I'm looking to solve thew.objectsissue before trying to write tests to confirm it works and/or changingrender_with_Makieto not highlight occluded spaces in the agent view.Also, it's beyond me why this branch has every commit I've ever made on my fork. If anyone knows how to fix that, I'd greatly appreciate it.