Merge release-17.5.0-9150: Release Twisted 17.5

Author: hawkowl Reviewer: markrwilliams Fixes: ticket:9150
JanMalte · Jun 11, 2017 · 02a3221 · 02a3221
2 parents 55a26dc + cd2ab20
commit 02a3221
Show file tree

Hide file tree

Showing 70 changed files with 197 additions and 48 deletions.
diff --git a/NEWS.rst b/NEWS.rst
@@ -3,6 +3,187 @@ http://twistedmatrix.com/trac/ticket/<number>
 
 .. towncrier release notes start
 
+Twisted 17.5.0 (2017-06-04)
+===========================
+
+Bugfixes
+--------
+
+- spawnProcess no longer opens an unwanted console on Windows (#5726)
+- The transition to the hyperlink package adds IPv6 support to
+  twisted.python.url.URL. This is now deprecated and new code should use
+  hyperlink directly (see #9126). (#8069)
+- twisted.logger now buffers only 200 events by default (reduced from 65536)
+  while waiting for observers to be configured. (#8164)
+- The transition of twisted.python.url to using the hyperlink package enables a
+  URL.click() with no arguments (or 0-length string argument) to resolve dot
+  segments in the path. (#8184)
+- twisted.protocols.finger now works on Python 3. (#8230)
+- TLS-related tests now pass when run with OpenSSL 1.1.0. This makes tests pass
+  again on macOS and Windows, as cryptography 1.8 and later include OpenSSL
+  1.1.0. (#8898)
+- UNIX socket endpoints now process all messages from recvmsg's ancillary data
+  via twisted.internet.unix.Server.doRead/twisted.internet.unix.Client.doRead,
+  while discarding and logging ones that don't contain file descriptors.
+  (#8912)
+- twisted.internet.endpoints.HostnameEndpoint and twisted.web.client.Agent work
+  again with reactors that do not provide IReactorPluggableNameResolver. This
+  undoes the changes that broke downstream users such as treq.testing. Note
+  that passing reactors that do not provide IReactorPluggableNameResolver to
+  either is deprecated. (#9032)
+- A Python 3 Perspective Broker server which receives a remote call with
+  keyword arguments from a Python 2 client will now decode any keys which are
+  binary to strings instead of crashing. This fixes interoperability between
+  Python 2 Buildbot clients and Python 3 Buildbot servers. (#9047)
+- twisted.internet._threadedselect now works on both Python 2 and 3. (#9053)
+- twisted.internet.interfaces.IResolverSimple implementers will now always be
+  passed bytes, properly IDNA encoded if required, on Python 2. On Python 3,
+  they will now be passed correctly IDNA-encoded Unicode forms of the domain,
+  taking advantage of the idna library from PyPI if possible. This is to avoid
+  Python's standard library (which has an out of date idna module) from mis-
+  encoding domain names when non-ASCII Unicode is passed to it. (#9137)
+
+
+Improved Documentation
+----------------------
+
+- The examples in Twisted howto "Using the Twisted Application Framework",
+  section "Customizing twistd logging" have been updated to use latest logging
+  modules and syntax (#9084)
+
+
+Features
+--------
+
+- twisted.internet.defer.Deferred.asFuture and
+  twisted.internet.defer.Deferred.fromFuture were added, allowing for easy
+  transitions between asyncio coroutines (which await Futures) and twisted
+  coroutines (which await Deferreds). (#8748)
+- twisted.application.internet.ClientService.whenConnected now accepts an
+  argument "failAfterFailures". If you set this to 1, the Deferred returned by
+  whenConnected will errback when the connection attempt fails, rather than
+  retrying forever. This lets you react (probably by stopping the
+  ClientService) to connection errors that are likely to be persistent, such as
+  using the wrong hostname, or not being connected to the internet at all.
+  (#9116)
+- twisted.protocols.tls.TLSMemoryBIOProtocol and anything that uses it
+  indirectly including the TLS client and server endpoints now enables TLS 1.3
+  cipher suites. (#9128)
+
+
+Misc
+----
+
+- #8133, #8995, #8997, #9003, #9015, #9021, #9026, #9027, #9049, #9057, #9062,
+  #9065, #9069, #9070, #9072, #9074, #9075, #9111, #9117, #9140, #9144, #9145
+
+
+Deprecations and Removals
+-------------------------
+
+- twisted.runner.inetdconf.InvalidRPCServicesConfError,
+  twisted.runner.inetdconf.RPCServicesConf, twisted.runner.inetdtap.RPCServer,
+  and twisted.runner.portmap, deprecated since 16.2.0, have been removed.
+  (#8464)
+- twisted.python.url and twisted.python._url were modified to rely on
+  hyperlink, a new package based on the Twisted URL implementation. Hyperlink
+  adds support for IPv6 (fixing #8069), correct username/password encoding,
+  better scheme/netloc inference, improved URL.click() behavior (fixing #8184),
+  and more. For full docs see hyperlink.readthedocs.io and the CHANGELOG in the
+  hyperlink GitHub repo. (#9126)
+
+
+Conch
+-----
+
+Bugfixes
+~~~~~~~~
+
+- History-aware terminal protocols like twisted.conch.manhole.Manhole no longer
+  raise a TypeError when a user visits a partial line they added to the command
+  line history by pressing up arrow before return. (#9031)
+- The telnet_echo.tac example had conflicting port callouts between runtime and
+  documentation. File was altered to run on documented port, 6023. (#9055)
+
+
+Deprecations and Removals
+~~~~~~~~~~~~~~~~~~~~~~~~~
+
+- Remove diffie-hellman-group1-sha1 from twisted.conch. See https://weakdh.org/
+  (#9019)
+- Removed small and obscure elliptic curves from conch. The only curves conch
+  supports now are the ones also supported by OpenSSH. (#9088)
+
+
+Mail
+----
+
+Bugfixes
+~~~~~~~~
+
+- twisted.mail.smtp has been ported to Python 3. (#8770)
+
+
+Names
+-----
+
+Bugfixes
+~~~~~~~~
+
+- RRHeader now converts its ttl argument to an integer, raising a TypeError if
+  it cannot. (#8340)
+
+
+Web
+---
+
+Bugfixes
+~~~~~~~~
+
+- twisted.web.cgi now works on Python 3 (#8009)
+- twisted.web.distrib now works on Python 3 (#8010)
+- twisted.web.http.HTTPFactory now propagates its reactor's callLater method to
+  the HTTPChannel object, rather than having callLater grab the global reactor.
+  This prevents the possibility of HTTPFactory logging using one reactor, but
+  HTTPChannel running timeouts on another. (#8904)
+
+
+Improved Documentation
+~~~~~~~~~~~~~~~~~~~~~~
+
+- twisted.web.template.flattenString docstring now correctly references
+  io.BytesIO (rather than NativeStringIO). (#9028)
+
+
+Features
+~~~~~~~~
+
+- twisted.web.client now exposes the RequestGenerationFailed exception type.
+  (#5310)
+- twisted.web.client.Agent will now parse responses that begin with a status
+  line that is missing a phrase. (#7673)
+- twisted.web.http.HTTPChannel and twisted.web._http2.H2Connection have been
+  enhanced so that after they time out they wait a small amount of time to
+  allow the connection to close gracefully and, if it does not, they forcibly
+  close it to avoid allowing malicious clients to forcibly keep the connection
+  open. (#8902)
+
+
+Misc
+~~~~
+
+- #8981, #9018, #9067, #9090, #9092, #9093, #9096
+
+
+Words
+-----
+
+Deprecations and Removals
+~~~~~~~~~~~~~~~~~~~~~~~~~
+
+- twisted.words.protocols.oscar, which is client code for Oscar/ICQ, was
+  deprecated in 16.2.0 and has now been removed. (#9024)
+
 
 Twisted Core 17.1.0 (2017-02-04)
 ================================

diff --git a/README.rst b/README.rst
@@ -1,4 +1,4 @@
-Twisted 17.1.0
+Twisted 17.5.0
 ==============
 
 |pypi|
@@ -8,9 +8,11 @@ Twisted 17.1.0
 
 .. code::
 
-    <hawkowl> we have always been at war with 16.7
+    <lukasa> Shhh
+    <lukasa> Don't think about it
+    <lukasa> Just let the asynchrony wash over you
 
-For information on what's new in Twisted 17.1.0, see the `NEWS <NEWS>`_ file that comes with the distribution.
+For information on what's new in Twisted 17.5.0, see the `NEWS <NEWS>`_ file that comes with the distribution.
 
 
 What is this?

diff --git a/docs/fun/Twisted.Quotes b/docs/fun/Twisted.Quotes
@@ -1,7 +1,3 @@
-<lukasa> Shhh
-<lukasa> Don't think about it
-<lukasa> Just let the asynchrony wash over you
-%
 <hawkowl> does this mean I can go eat a whole packet of chocolate biscuits
 <hawkowl> because ultimately entropy will mean it never meant anything
 <exarkun> I don't see how it could mean _not_ to do that.

diff --git a/docs/historic/Quotes/Twisted-17.5 b/docs/historic/Quotes/Twisted-17.5
@@ -0,0 +1,3 @@
+<lukasa> Shhh
+<lukasa> Don't think about it
+<lukasa> Just let the asynchrony wash over you
diff --git a/src/twisted/_version.py b/src/twisted/_version.py
@@ -7,5 +7,5 @@
 
 from incremental import Version
 
-__version__ = Version('Twisted', 17, 1, 0, dev=0)
+__version__ = Version('Twisted', 17, 5, 0)
 __all__ = ["__version__"]
diff --git a/src/twisted/conch/newsfragments/9019.removal b/src/twisted/conch/newsfragments/9019.removal
diff --git a/src/twisted/conch/newsfragments/9031.bugfix b/src/twisted/conch/newsfragments/9031.bugfix
diff --git a/src/twisted/conch/newsfragments/9055.bugfix b/src/twisted/conch/newsfragments/9055.bugfix
diff --git a/src/twisted/conch/newsfragments/9088.removal b/src/twisted/conch/newsfragments/9088.removal
diff --git a/src/twisted/internet/defer.py b/src/twisted/internet/defer.py
@@ -762,7 +762,7 @@ def asFuture(self, loop):
             C{self} into a L{Deferred} firing with L{None}, regardless of what
             its result previously would have been.
 
-        @since: Twisted NEXT
+        @since: Twisted 17.5.0
 
         @param loop: The asyncio event loop to bind the L{asyncio.Future} to.
         @type loop: L{asyncio.AbstractEventLoop} or similar
@@ -808,7 +808,7 @@ def fromFuture(cls, future):
             not a L{asyncio.Future}.  (The length of this list of techniques is
             exactly why we have left it to the caller!)
 
-        @since: Twisted NEXT
+        @since: Twisted 17.5.0
 
         @param future: The Future to adapt.
         @type future: L{asyncio.Future}

diff --git a/src/twisted/internet/endpoints.py b/src/twisted/internet/endpoints.py
@@ -809,7 +809,7 @@ def _getNameResolverAndMaybeWarn(self, reactor):
         if not IReactorPluggableNameResolver.providedBy(reactor):
             warningString = deprecate.getDeprecationWarningString(
                 reactor.__class__,
-                Version("Twisted", "NEXT", 0, 0),
+                Version('Twisted', 17, 5, 0),
                 format=("Passing HostnameEndpoint a reactor that does not"
                         " provide IReactorPluggableNameResolver (%(fqpn)s)"
                         " was deprecated in %(version)s"),

diff --git a/src/twisted/internet/test/test_endpoints.py b/src/twisted/internet/test/test_endpoints.py
@@ -1974,7 +1974,7 @@ def test_deprecation(self):
             'Passing HostnameEndpoint a reactor that does not provide'
             ' IReactorPluggableNameResolver'
             ' (twisted.test.proto_helpers.MemoryReactorClock)'
-            ' was deprecated in Twisted NEXT;'
+            ' was deprecated in Twisted 17.5.0;'
             ' please use a reactor that provides'
             ' IReactorPluggableNameResolver instead'))
 

diff --git a/src/twisted/mail/newsfragments/8770.bugfix b/src/twisted/mail/newsfragments/8770.bugfix
diff --git a/src/twisted/names/newsfragments/8340.bugfix b/src/twisted/names/newsfragments/8340.bugfix
diff --git a/src/twisted/newsfragments/5726.bugfix b/src/twisted/newsfragments/5726.bugfix
diff --git a/src/twisted/newsfragments/8069.bugfix b/src/twisted/newsfragments/8069.bugfix
diff --git a/src/twisted/newsfragments/8133.misc b/src/twisted/newsfragments/8133.misc
diff --git a/src/twisted/newsfragments/8164.bugfix b/src/twisted/newsfragments/8164.bugfix
diff --git a/src/twisted/newsfragments/8184.bugfix b/src/twisted/newsfragments/8184.bugfix
diff --git a/src/twisted/newsfragments/8230.bugfix b/src/twisted/newsfragments/8230.bugfix
diff --git a/src/twisted/newsfragments/8464.removal b/src/twisted/newsfragments/8464.removal
diff --git a/src/twisted/newsfragments/8748.feature b/src/twisted/newsfragments/8748.feature
diff --git a/src/twisted/newsfragments/8898.bugfix b/src/twisted/newsfragments/8898.bugfix
diff --git a/src/twisted/newsfragments/8912.bugfix b/src/twisted/newsfragments/8912.bugfix
diff --git a/src/twisted/newsfragments/8995.misc b/src/twisted/newsfragments/8995.misc
diff --git a/src/twisted/newsfragments/8997.misc b/src/twisted/newsfragments/8997.misc
diff --git a/src/twisted/newsfragments/9003.misc b/src/twisted/newsfragments/9003.misc
diff --git a/src/twisted/newsfragments/9015.misc b/src/twisted/newsfragments/9015.misc
diff --git a/src/twisted/newsfragments/9021.misc b/src/twisted/newsfragments/9021.misc
diff --git a/src/twisted/newsfragments/9026.misc b/src/twisted/newsfragments/9026.misc
diff --git a/src/twisted/newsfragments/9027.misc b/src/twisted/newsfragments/9027.misc
diff --git a/src/twisted/newsfragments/9032.bugfix b/src/twisted/newsfragments/9032.bugfix
diff --git a/src/twisted/newsfragments/9047.bugfix b/src/twisted/newsfragments/9047.bugfix
diff --git a/src/twisted/newsfragments/9049.misc b/src/twisted/newsfragments/9049.misc
diff --git a/src/twisted/newsfragments/9053.bugfix b/src/twisted/newsfragments/9053.bugfix
diff --git a/src/twisted/newsfragments/9057.misc b/src/twisted/newsfragments/9057.misc
diff --git a/src/twisted/newsfragments/9062.misc b/src/twisted/newsfragments/9062.misc
diff --git a/src/twisted/newsfragments/9065.misc b/src/twisted/newsfragments/9065.misc
diff --git a/src/twisted/newsfragments/9069.misc b/src/twisted/newsfragments/9069.misc
diff --git a/src/twisted/newsfragments/9070.misc b/src/twisted/newsfragments/9070.misc
diff --git a/src/twisted/newsfragments/9072.misc b/src/twisted/newsfragments/9072.misc
diff --git a/src/twisted/newsfragments/9074.misc b/src/twisted/newsfragments/9074.misc
diff --git a/src/twisted/newsfragments/9075.misc b/src/twisted/newsfragments/9075.misc
diff --git a/src/twisted/newsfragments/9084.doc b/src/twisted/newsfragments/9084.doc
diff --git a/src/twisted/newsfragments/9111.misc b/src/twisted/newsfragments/9111.misc
diff --git a/src/twisted/newsfragments/9116.feature b/src/twisted/newsfragments/9116.feature
diff --git a/src/twisted/newsfragments/9117.misc b/src/twisted/newsfragments/9117.misc
diff --git a/src/twisted/newsfragments/9126.removal b/src/twisted/newsfragments/9126.removal
diff --git a/src/twisted/newsfragments/9128.feature b/src/twisted/newsfragments/9128.feature
diff --git a/src/twisted/newsfragments/9137.bugfix b/src/twisted/newsfragments/9137.bugfix
diff --git a/src/twisted/newsfragments/9140.misc b/src/twisted/newsfragments/9140.misc
diff --git a/src/twisted/newsfragments/9144.misc b/src/twisted/newsfragments/9144.misc
diff --git a/src/twisted/newsfragments/9145.misc b/src/twisted/newsfragments/9145.misc
diff --git a/src/twisted/python/__init__.py b/src/twisted/python/__init__.py
@@ -19,7 +19,7 @@
 
 
 deprecatedModuleAttribute(
-    Version("Twisted", "NEXT", 0, 0),
+    Version('Twisted', 17, 5, 0),
     "Please use hyperlink from PyPI instead.",
     "twisted.python", "url")
 

diff --git a/src/twisted/python/test/test_url.py b/src/twisted/python/test/test_url.py
@@ -806,14 +806,14 @@ class URLDeprecationTests(SynchronousTestCase):
     """
     def test_urlDeprecation(self):
         """
-        L{twisted.python.url} is deprecated since Twisted NEXT.
+        L{twisted.python.url} is deprecated since Twisted 17.5.0.
         """
         from twisted.python import url
         url
 
         warningsShown = self.flushWarnings([self.test_urlDeprecation])
         self.assertEqual(1, len(warningsShown))
         self.assertEqual(
-            ("twisted.python.url was deprecated in Twisted NEXT:"
+            ("twisted.python.url was deprecated in Twisted 17.5.0:"
              " Please use hyperlink from PyPI instead."),
             warningsShown[0]['message'])
diff --git a/src/twisted/web/newsfragments/5310.feature b/src/twisted/web/newsfragments/5310.feature
diff --git a/src/twisted/web/newsfragments/7673.feature b/src/twisted/web/newsfragments/7673.feature
diff --git a/src/twisted/web/newsfragments/8009.bugfix b/src/twisted/web/newsfragments/8009.bugfix
diff --git a/src/twisted/web/newsfragments/8010.bugfix b/src/twisted/web/newsfragments/8010.bugfix
diff --git a/src/twisted/web/newsfragments/8902.feature b/src/twisted/web/newsfragments/8902.feature
diff --git a/src/twisted/web/newsfragments/8904.bugfix b/src/twisted/web/newsfragments/8904.bugfix
diff --git a/src/twisted/web/newsfragments/8981.misc b/src/twisted/web/newsfragments/8981.misc
diff --git a/src/twisted/web/newsfragments/9018.misc b/src/twisted/web/newsfragments/9018.misc
diff --git a/src/twisted/web/newsfragments/9028.doc b/src/twisted/web/newsfragments/9028.doc
diff --git a/src/twisted/web/newsfragments/9067.misc b/src/twisted/web/newsfragments/9067.misc
diff --git a/src/twisted/web/newsfragments/9090.misc b/src/twisted/web/newsfragments/9090.misc
diff --git a/src/twisted/web/newsfragments/9092.misc b/src/twisted/web/newsfragments/9092.misc
diff --git a/src/twisted/web/newsfragments/9093.misc b/src/twisted/web/newsfragments/9093.misc
diff --git a/src/twisted/web/newsfragments/9096.misc b/src/twisted/web/newsfragments/9096.misc
diff --git a/src/twisted/words/newsfragments/9024.removal b/src/twisted/words/newsfragments/9024.removal