Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalArgumentException: Cannot copy null stack in ItemStackMixin_NeoForge #1550

Merged
merged 7 commits into from
Nov 16, 2024
Merged

Fix IllegalArgumentException: Cannot copy null stack in ItemStackMixin_NeoForge #1550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ae5049e
Fix IllegalArgumentException: Cannot copy null stack in ItemStackMixi…
LabsZero Nov 13, 2024
54331d3
Update ItemStackMixin_NeoForge.java
LabsZero Nov 16, 2024
32cceca
Update ItemStackMixin_NeoForge.java
LabsZero Nov 16, 2024
bf03b90
Update ItemStackMixin_NeoForge.java
LabsZero Nov 16, 2024
3663a40
Update build.gradle
LabsZero Nov 16, 2024
d869dc7
Update ItemStackMixin_NeoForge.java
LabsZero Nov 16, 2024
7a0f570
Fixed build failing
LabsZero Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...c/main/java/io/izzel/arclight/neoforge/mixin/core/world/item/ItemStackMixin_NeoForge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,11 @@ public abstract class ItemStackMixin_NeoForge implements ItemStackBridge, IItemS
// @formatter:on

@Decorate(method = "hurtAndBreak(ILnet/minecraft/server/level/ServerLevel;Lnet/minecraft/world/entity/LivingEntity;Ljava/util/function/Consumer;)V",
at = @At(value = "INVOKE", target = "Lnet/minecraft/world/item/enchantment/EnchantmentHelper;processDurabilityChange(Lnet/minecraft/server/level/ServerLevel;Lnet/minecraft/world/item/ItemStack;I)I"))
at = @At(value = "INVOKE", target = "Lnet/minecraft/world/item/enchantment/EnchantmentHelper;processDurabilityChange(Lnet/minecraft/server/level/ServerLevel;Lnet/minecraft/world/item/ItemStack;I)I"))
private int arclight$itemDamage(ServerLevel serverLevel, ItemStack itemStack, int i, @Local(ordinal = 0) LivingEntity damager) throws Throwable {
if (itemStack == null) {
itemStack = ItemStack.EMPTY;
}
int result = (int) DecorationOps.callsite().invoke(serverLevel, itemStack, i);
if (damager instanceof ServerPlayer) {
PlayerItemDamageEvent event = new PlayerItemDamageEvent(((ServerPlayerEntityBridge) damager).bridge$getBukkitEntity(), CraftItemStack.asCraftMirror((ItemStack) (Object) this), result);
Expand All @@ -64,7 +67,9 @@ public abstract class ItemStackMixin_NeoForge implements ItemStackBridge, IItemS
}

@Deprecated
public void setItem(Item item) {
public void setItem(@Nullable Item item) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, there shouldn't be an ItemStack with a null item, it should be Items.AIR instead.

if (item == null) { return;
}
this.item = item;
}

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ allprojects {
fabricLoaderVersion = '0.16.9'
fabricApiVersion = '0.108.0+1.21.1'
forgeVersion = '52.0.28'
neoForgeVersion = '21.1.77'
neoForgeVersion = '21.1.79'
apiVersion = '1.7.3'
toolsVersion = '1.3.0'
mixinVersion = '0.8.5'
Expand Down
Loading