Fix IllegalArgumentException: Cannot copy null stack in ItemStackMixin_NeoForge #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n_NeoForge Fixes IllegalArgumentException: Cannot copy null stack reported in server logs.
LabsZero
changed the title
qyl27
requested changes
Nov 14, 2024
| @@ -64,7 +69,7 @@ public abstract class ItemStackMixin_NeoForge implements ItemStackBridge, IItemS | |||
| } | |||
|
|
|||
| @Deprecated | |||
| public void setItem(Item item) { | |||
| public void setItem(@Nullable Item item) { | |||
There was a problem hiding this comment.
As far as I know, there shouldn't be an ItemStack with a null item, it should be Items.AIR instead.
| private int arclight$itemDamage(ServerLevel serverLevel, ItemStack itemStack, int i, @Local(ordinal = 0) LivingEntity damager) throws Throwable { | ||
| // Added null check for itemStack |
There was a problem hiding this comment.
Would you mind figuring out which method passed a null as ItemStack into this method?
In Minecraft modding, these should all be replaced by ItemStack,EMPTY. If it happened in NeoForge, perhaps it was their bug.
There was a problem hiding this comment.
Sure i will look into it asap
5 tasks
|
ignore my last pull request still looking into the matter. |
LabsZero
commented
Nov 16, 2024
qyl27
approved these changes
Nov 16, 2024
|
Although I am still confused as to why the |
|
I think the root problem is in And I have solved it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IllegalArgumentException: Cannot copy null stack reported in server logs.