[Whisper] Update korean i18n (ko-kr.conf) #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Better not keep English values in korean file. The default fallback should be en_us in recent versions. |
|
OK, got it and now I'm working some more work localizing extra lines still in English rn.. but it'll take time- like a week or two. |
Likely no English-only string remains so far
Managed to do it in hours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time has passed from #1037 , and there were some huge changes. However, the i18n for Korean (which I lastly managed) is not updated- quite a lot that the default fallback, Classic Chinese, would appear even the setting is correct as Korean.
So for now, I'm making this PR to update the i18n file to fix that issue.
ko-kr.conf:毕宿 (Net)and附耳 (Whisper), untranslated fromen-ussymlink-file-existandlightcity-not-installed, untranslated fromen-usoptimization.disable-data-fixer.commentcompatibility.valid-username-regex.commentandvelocity.*velocity.*is untranslated fromen-us