refactor YAML_Template to yaml module #1984
Conversation
Polber
force-pushed
the
jkinard/yaml-refactor
branch
from
59bb5c7 to
60803ae
Compare
Polber
force-pushed
the
jkinard/yaml-refactor
branch
from
60803ae to
3bb3674
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1984 +/- ##
============================================
- Coverage 45.27% 45.26% -0.02%
- Complexity 3632 3956 +324
============================================
Files 836 836
Lines 49872 49877 +5
Branches 5253 5255 +2
============================================
- Hits 22579 22576 -3
- Misses 25618 25627 +9
+ Partials 1675 1674 -1
|
Polber
force-pushed
the
jkinard/yaml-refactor
branch
18 times, most recently
from
c682671 to
677650b
Compare
Polber
force-pushed
the
jkinard/yaml-refactor
branch
from
677650b to
9486382
Compare
Signed-off-by: Jeffrey Kinard <jeff@thekinards.com>
Polber
force-pushed
the
jkinard/yaml-refactor
branch
from
9486382 to
6ca0025
Compare
| paths: | ||
| - '**.java' | ||
| - '**.xml' | ||
| # Include python files and Dockerfiles used for YAML and xlang templates. | ||
| - '**.py' | ||
| - 'plugins/core-plugin/src/main/resources/**' | ||
| # Include relevant GitHub Action files for running these checks. | ||
| # This will make it easier to verify action changes don't break anything. | ||
| - '.github/actions/setup-env/*' | ||
| - '.github/workflows/java-pr.yml' |
There was a problem hiding this comment.
Do we actually need all of these paths?
There was a problem hiding this comment.
It seems like this should be scoped to yaml
There was a problem hiding this comment.
Also, is this workflow a subset of the java-pr workflow? If so, we should get rid of the checkstyle/spotless checks below
| flags.CloudProxyPostgresPort(), | ||
| flags.CloudProxyPassword(), | ||
| flags.UnifiedWorkerHarnessContainerImage(), | ||
| flags.CloudProxyPassword()) |
There was a problem hiding this comment.
Not for this PR, but it seems like we're duplicating the same set of flags over and over; I think there's a big code deletion PR we could do where we refactor into a single location.
There was a problem hiding this comment.
Please don't take this as a "go and do this", though, I think in general I don't think we should be doing a ton of these cleanup PRs unless we can justify the time savings.
| @@ -1,227 +0,0 @@ | |||
|
|
|||
| Kafka to BigQuery (YAML) template | |||
There was a problem hiding this comment.
Why did we get rid of the kafka pieces here?
| # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| # License for the specific language governing permissions and limitations under | ||
| # the License. | ||
| # |
There was a problem hiding this comment.
Why don't we need this file anymore?
This PR refactors the organization of the Yaml_Template and its related files by creating a new yaml module.
This PR also adds a new workflow for triggering YAML-related tests separately. This will be useful as new ITs are added to keep from slowing down the workflow for Java PRs