Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update URLs for import into DevSite #1974

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Update URLs for import into DevSite #1974

wants to merge 18 commits into from

Conversation

rszper
Copy link
Contributor

@rszper rszper commented Oct 29, 2024

  • Add code tags to URLs that are examples and aren't meant to resolve. Currently, when imported to DevSite, these URLs are turned into links. The code tags make them examples instead of links.
  • Fix broken neo4j link.
  • Minor text updates.

rszper added 18 commits October 23, 2024 16:53
@rszper
Update ImportPipeline.java
8af699e 
Add code markers around the sample URL so that it renders as an example rather than as a URL when it's imported to DevSite.
@rszper
Merge pull request #1 from rszper/rszper-spanner-URL
f35ccbb 
Update ImportPipeline.java
@rszper
Update ElasticsearchWriteOptions.java
943628a 
Add code marking around examples URLs.
@rszper
Update ExportPipeline.java
79c4149
@rszper
Update TextImportPipeline.java
2392827
@rszper
Update SpannerConverters.java
de7fd4a
@rszper
Update SpannerVectorEmbeddingExport.java
7785aed
@rszper
Update SpannerChangeStreamsToBigQueryOptions.java
7dd2896
@rszper
Update SourceDbToSpannerOptions.java
0e936e6
@rszper
Update DataStreamToSpanner.java
b6175d0
@rszper
Update SpannerChangeStreamsToGcsOptions.java
14026c4
@rszper
Update SpannerChangeStreamsToPubSubOptions.java
80446e0
@rszper
Update DataStreamToSQL.java
0123f34
@rszper
Update DataStreamToPostgres.java
1b45b8e
@rszper
Update README_Cloud_Datastream_to_BigQuery.md
ebfb8fe
@rszper
Update DataStreamToBigQuery.java
c64bbe5
@rszper
Update GoogleCloudToNeo4j.java
b32b93c 
Fix broken URL
@rszper
Update DatadogConverters.java
ceabdab
@rszper rszper requested review from a team as code owners October 29, 2024 20:19
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.09%. Comparing base (97e7640) to head (ceabdab).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##               main    #1974    +/-   ##
==========================================
  Coverage     45.08%   45.09%            
- Complexity     3608     3936   +328     
==========================================
  Files           835      835            
  Lines         49693    49703    +10     
  Branches       5230     5232     +2     
==========================================
+ Hits          22406    22415     +9     
- Misses        25620    25622     +2     
+ Partials       1667     1666     -1
Components Coverage Δ
spanner-templates 66.27% <ø> (+0.02%) ⬆️
spanner-import-export 64.20% <ø> (+0.02%) ⬆️
spanner-live-forward-migration 76.18% <ø> (ø)
spanner-live-reverse-replication 76.54% <ø> (ø)
spanner-bulk-migration 85.57% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
.../google/cloud/teleport/spanner/ExportPipeline.java 0.00% <ø> (ø)
.../google/cloud/teleport/spanner/ImportPipeline.java 0.00% <ø> (ø)
...gle/cloud/teleport/spanner/TextImportPipeline.java 0.00% <ø> (ø)
...leport/templates/SpannerVectorEmbeddingExport.java 0.00% <ø> (ø)
...d/teleport/templates/common/DatadogConverters.java 81.25% <ø> (ø)
...d/teleport/templates/common/SpannerConverters.java 76.92% <ø> (ø)
...ud/teleport/v2/templates/DataStreamToBigQuery.java 0.00% <ø> (ø)
...ud/teleport/v2/templates/DataStreamToPostgres.java 0.00% <ø> (ø)
...oud/teleport/v2/templates/DataStreamToSpanner.java 9.40% <ø> (ø)
...e/cloud/teleport/v2/templates/DataStreamToSQL.java 4.68% <ø> (ø)
... and 1 more

... and 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asthamohta asthamohta Awaiting requested review from asthamohta asthamohta is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@VardhanThigle VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rszper