Restyle PageAside to use sidebar list styles
#2680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0aa669 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
GitBook Preview |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
valentin0h
reviewed
Jan 8, 2025
packages/gitbook/src/components/RootLayout/CustomizationRootLayout.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Valentino Hudhra <2587839+valentin0h@users.noreply.github.com>
valentin0h
reviewed
Jan 8, 2025
valentin0h
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new sidebar list styles introduced in #2645 to the right sidebar, along with improved top margin and visual cleanup of the right sidebar as a whole.
New list styles
Same as left sidebar:
default,pill, andline(using the same user customisation setting).default.mov
pill.mov
line.mov
In addition to the three styles, when a user's system reports wanting more contrast, all three styles get more borders and thicker text:
default-contrast.mov
API blocks
Before & After