-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Cannot change playback speed to 1 if default is 1.25 #6363
Comments
I can replicate this as well. I don't see any recently changed code in FreeTube that's touched this, so I suspect this may be an upstream issue like #6281. |
What's odd is that it lets you change the speed to everything else except 1 and, also, that it works correctly in the current "Release" build; it seems to only be an issue with the nightly ones... |
In our logic, we supply the |
@kommunarr im unable to test myself so could you verify this on https://nightly-dot-shaka-player-demo.appspot.com/ |
@efb4f5ff-1298-471a-8973-3d47447115dc Not sure how to test with a |
Ah my bad. Maybe the change could be related to this weird upstream bug #6281 |
The root cause it the same for all 3 problems, shaka-player changed the way that the UI sets the playback rate with 4.12.x (FreeTube 0.22.0 uses 4.11.10 as 0.12.x was released later). They have fixed the resetting of the playback rate on the main branch/nightly demo but the video still starts playing when you select a playback rate and this issue happens on the nightly demo too. When the page loads run |
96bcdc3 fixed the speed being reset on play/pause, but I still can't switch to x1 playback speed by clicking if I have x2 by default. |
That is entirely expected, because as explained in my comment right above yours, they have only fixed 1/3 issues so far. |
Guidelines
Describe the bug
I set the default playback speed to 1.25. While watching a video playing at my default speed (1.25), I decided I wanted to slow it down to normal speed so I went to change the speed while the video was playing but it would not let me select 1. It lets you select all other playback speeds except for 1. This works fine in the official v0.22.0 Beta release but not in the current (and recent) nightly builds, which I grabbed to fix the issue of the audio track defaulting to German on some videos.
Expected Behavior
It your default playback speed is set to 1.25, the player should allow you to select 1 for a playback speed while the video is playing.
Issue Labels
feature stopped working
FreeTube Version
v0.22.0-nightly-5301 Beta
Operating System Version
Windows 11 24H2
Installation Method
Portable
Primary API used
Local API
Last Known Working FreeTube Version (If Any)
v0.22.0 Beta
Additional Information
No response
Nightly Build
The text was updated successfully, but these errors were encountered: