Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Add slash key \ shortcut to search bar #6352

Closed
3 tasks done
anddam opened this issue Dec 11, 2024 · 9 comments
Closed
3 tasks done

[Feature Request]: Add slash key \ shortcut to search bar #6352

anddam opened this issue Dec 11, 2024 · 9 comments
Labels
E: ease of use improvement enhancement New feature or request U: duplicate This issue or pull request already exists

Comments

@anddam
Copy link

anddam commented Dec 11, 2024 •
edited
Loading

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

YouTube has a / slash key shortcut to focus the search bar.

Proposed Solution

Please add a slash key / as additional shortcut (along with ctrl-l and alt-d) to search, this used to be a Google Web Search default (seems it is not anymore) and is actually a default shortcut on YouTube and other web search engine like DuckDuckGo.

Alternatives Considered

Not sure what should go here, I might… not use the slash key as shortcut, I guess.

Issue Labels

ease of use improvement

Additional Information

No response

edit: for some reason I typed a backslash in place of a slash, I edited the OP but cannot edit the title now
@anddam anddam added the enhancement New feature or request label Dec 11, 2024
@devloberto
Copy link

Hey there ✌🏼 I was searching for a shortcut to enter the search bar too.
I tried the common ones ctrl + k and / (shift + 7 as well as the numpad /).

Since there is already a shortcut implemented to focus the search bar, it should be easy to add more:

FreeTube/src/renderer/App.js

Line 354 in 550ce77

handleKeyboardShortcuts: function (event) {

Just to phrase an user story:
As a busy user I don't want to need to leave my keyboard and search for my mouse to select the search box because I don't want to waste my time.

So I suggest following acceptance criterion:
Focus the search bar when one of the following shortcuts is typed:

  • ctrl+k
  • shift+7 (slash)
  • / (numpad slash)

I will open a PR 🙂

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

We have alt + d and ctrl + l to navigate to the searchbar, see https://docs.freetubeapp.io/usage/keyboard-shortcuts/. I dont see why we need more

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@devloberto if u create a PR then only create it for the requested shortcut.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

this is a duplicate of #2138

@github-actions github-actions bot added the U: duplicate This issue or pull request already exists label Dec 28, 2024
@devloberto
Copy link

thx for pointing out the duplicate

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

As far as why some of them were different, there were concerns with the shortcuts that YouTube uses for those with Non US / Standard layouts. Keys like / and > are mapped differently and more difficult to press on these type of layouts. The alternative that we used for the search bar, Alt + D was picked because this was the shortcut that Firefox uses for focusing their search bar and was more accessible across layouts.

Retrieved from #2138 (comment)

@devloberto
Copy link

Oh I see! I wondered why Alt + D was defined but that makes totally sense 👍🏼 thank you

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

Yeah i totally forgot about the reasons for it too. It was a long time ago haha

@anddam
Copy link
Author

anddam commented Dec 30, 2024

I dont see why we need more

The reason for asking was consistency with YT interface that I think is more on point for FreeTube users compared to FF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E: ease of use improvement enhancement New feature or request U: duplicate This issue or pull request already exists
Projects
Feature Requests
Status: To assign
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anddam @devloberto @efb4f5ff-1298-471a-8973-3d47447115dc