PHPStan Level 6.

FXdSP · Jul 28, 2020 · d739a69 · d739a69
1 parent c6c3d37
commit d739a69
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 11 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,7 +1,7 @@
 includes:
     - phpstan-baseline.neon
 parameters:
-    level: 5
+    level: 6
     checkGenericClassInNonGenericObjectType: false
     checkMissingIterableValueType: false
     paths:

diff --git a/src/Propel/Runtime/DataFetcher/AbstractDataFetcher.php b/src/Propel/Runtime/DataFetcher/AbstractDataFetcher.php
@@ -8,7 +8,7 @@
 abstract class AbstractDataFetcher implements DataFetcherInterface
 {
     /**
-     * @var mixed
+     * @var mixed|null
      */
     protected $dataObject;
 
@@ -21,15 +21,17 @@ public function __construct($dataObject)
     }
 
     /**
-     * @inheritDoc
+     * @param mixed|null $dataObject
+     *
+     * @return void
      */
     public function setDataObject($dataObject)
     {
         $this->dataObject = $dataObject;
     }
 
     /**
-     * @return \Propel\Runtime\DataFetcher\PDODataFetcher
+     * @return mixed
      */
     public function getDataObject()
     {

diff --git a/src/Propel/Runtime/DataFetcher/PDODataFetcher.php b/src/Propel/Runtime/DataFetcher/PDODataFetcher.php
@@ -64,7 +64,7 @@ public function getStyle()
     }
 
     /**
-     * @param null $style
+     * @param int|null $style
      *
      * @return array|null
      */

diff --git a/src/Propel/Runtime/Util/PropelDateTime.php b/src/Propel/Runtime/Util/PropelDateTime.php
@@ -49,20 +49,18 @@ protected static function isTimestamp($value)
         if (!is_numeric($value)) {
             return false;
         }
-
         if (strlen((string)$value) === 8) {
             return false;
         }
 
-        $stamp = strtotime($value);
-
+        $stamp = strtotime((string)$value);
         if ($stamp === false) {
             return true;
         }
 
-        $month = (int)date('m', $value);
-        $day = (int)date('d', $value);
-        $year = (int)date('Y', $value);
+        $month = (int)date('m', (int)$value);
+        $day = (int)date('d', (int)$value);
+        $year = (int)date('Y', (int)$value);
 
         return checkdate($month, $day, $year);
     }

diff --git a/tests/Propel/Tests/Runtime/Util/PropelDateTimeTest.php b/tests/Propel/Tests/Runtime/Util/PropelDateTimeTest.php
@@ -214,6 +214,7 @@ public function testIsTimestamp()
     {
         $this->assertEquals(false, TestPropelDateTime::isTimestamp('20110325'));
         $this->assertEquals(true, TestPropelDateTime::isTimestamp(1319580000));
+        $this->assertEquals(true, TestPropelDateTime::isTimestamp('1319580000'));
         $this->assertEquals(false, TestPropelDateTime::isTimestamp('2011-07-20 00:00:00'));
     }
 
@@ -246,6 +247,11 @@ public function testCreateHighPrecisioniTz()
 
 class TestPropelDateTime extends PropelDateTime
 {
+    /**
+     * @param mixed $value
+     *
+     * @return bool
+     */
     public static function isTimestamp($value)
     {
         return parent::isTimestamp($value);
-Original file line number
+Diff line change
@@ Expand Up / @@ -64,7 +64,7 @@ public function getStyle() @@
         }
         /**
-         * @param null $style
+         * @param int|null $style
          *
          * @return array|null
          */
@@ Expand Down @@