Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unknown fields #182

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Skip unknown fields #182

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9cab034
Add option to skip over unknown elements in nf9 and ipfix
dbardbar Jan 8, 2023
9ca2509
Add unit tests for unknown element
dbardbar Jan 8, 2023
bf56e51
Add unit tests for unknown element
dbardbar Jan 8, 2023
9cdc05f
Add unit tests for unknown element
dbardbar Jan 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit tests for unknown element
  • Loading branch information
@dbardbar
dbardbar committed Jan 8, 2023
commit 9ca25092f10b0f0e056848d699689c4102b0e6ed
40 changes: 40 additions & 0 deletions ipfix/decoder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,3 +230,43 @@ func TestDecodeDataTpl(t *testing.T) {
t.Error(err)
}
}

func TestUnknownElement(t *testing.T) {
// Single dataset, id 61166, 2 elements, element id 1, and element id 222, enterprise 7
var template = []byte{
0x00, 0x0a, 0x00, 0x20, 0x63, 0x75, 0x58, 0xb1, 0x19, 0x10, 0x70, 0x03, 0x00, 0x00, 0x00, 0x00,
0x00, 0x02, 0x00, 0x14, 0xee, 0xee, 0x00, 0x02, 0x00, 0x01, 0x00, 0x08, 0x80, 0xde, 0x00, 0x04,
0x00, 0x00, 0x00, 0x07}

var payload = []byte{
0x00, 0x0a, 0x00, 0x20, 0x63, 0x75, 0x58, 0xb1, 0x19, 0x10, 0x70, 0x04, 0x00, 0x00, 0x00, 0x00,
0xee, 0xee, 0x00, 0x10, 0x00, 0x00, 0x00, 0x11, 0x11, 0x11, 0x11, 0x11, 0x22, 0x22, 0x22, 0x22}

ip := net.ParseIP("127.0.0.1")
templates := GetCache("")
d := NewDecoder(ip, template, false)
_, err := d.Decode(templates)
if err != nil {
t.Error(err)
}

// Parse data with unknown element
d = NewDecoder(ip, payload, false)
m, err := d.Decode(templates)
if err == nil {
t.Error("Expected error due to unknown element, but got nil")
}
if len(m.DataSets) != 0 {
t.Error("Did not expect any result datasets, but got", m.DataSets)
}

// Now parse again, skip unknown element
d = NewDecoder(ip, payload, true)
m, err = d.Decode(templates)
if err != nil {
t.Error(err)
}
if len(m.DataSets) != 1 {
t.Error("Expected 1 dataset, but got", m.DataSets)
}
}