Issue 40:

Make the error message in the browser more meaningful when the file (i.e. div) cannot be openned. There is no unit test because it is browser-only code. During unit tests, open() calls turn into Sk.read() which handles missing files properly already.
Duncanr-glitch · Jan 24, 2013 · 5d984a6 · 5d984a6
1 parent fd83176
commit 5d984a6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/src/errors.js b/src/errors.js
@@ -166,3 +166,13 @@ Sk.builtin.TimeLimitError = function(args) { Sk.builtin.Exception.apply(this, ar
 goog.inherits(Sk.builtin.TimeLimitError, Sk.builtin.Exception);
 Sk.builtin.TimeLimitError.prototype.tp$name = "TimeLimitError";
 goog.exportSymbol("Sk.builtin.TimeLimitError", Sk.builtin.TimeLimitError);
+
+/**
+ * @constructor
+ * @extends Sk.builtin.Exception
+ * @param {...*} args
+ */
+Sk.builtin.IOError = function(args) { Sk.builtin.Exception.apply(this, arguments); }
+goog.inherits(Sk.builtin.IOError, Sk.builtin.Exception);
+Sk.builtin.IOError.prototype.tp$name = "IOError";
+goog.exportSymbol("Sk.builtin.IOError", Sk.builtin.IOError);
diff --git a/src/file.js b/src/file.js
@@ -10,10 +10,13 @@ Sk.builtin.file = function(name, mode, buffering)
     this.name = name;
     this.closed = false;
 	if ( Sk.inBrowser ) {  // todo:  Maybe provide a replaceable function for non-import files
-	    if (document.all) {
-		    this.data$ = document.getElementById(name.v).innerText;
+        var elem = document.getElementById(name.v);
+        if ( elem == null) {
+            throw new Sk.builtin.IOError("[Errno 2] No such file or directory: '"+name.v+"'");
+        } else if (document.all) {
+		    this.data$ = elem.innerText;
 	    } else { // stupid Firefox
-	        this.data$ = document.getElementById(name.v).textContent;
+	        this.data$ = elem.textContent;
 	    }
 	} else {
   		this.data$ = Sk.read(name.v);