Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add velo superchain bribes, volume/fees #2321

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: add velo superchain bribes, volume/fees #2321

merged 2 commits into from
Jan 17, 2025

Conversation

ethzoomer
Copy link
Contributor

Added bribes fetching from leaf Voter contract on the Superchain L2s for Velodrome. Added swaps fetching for the Superchain deployments on Mode + Lisk + Fraxtal. Left the Soneium and Ink deployments commented out for now because the backend doesn't seem to handle them yet

@llamabutler
Copy link

The velodrome-slipstream adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts dexs velodrome-slipstream

🦙 Running VELODROME-SLIPSTREAM adapter 🦙
---------------------------------------------------
Start Date:	Tue, 14 Jan 2025 12:25:42 GMT
End Date:	Wed, 15 Jan 2025 12:25:42 GMT
---------------------------------------------------

OPTIMISM 👇
Backfill start time: 6/3/2024
NO METHODOLOGY SPECIFIED
Daily volume: 74.20 M
Daily fees: 45.36 k
Daily revenue: 45.36 k
Daily holders revenue: 45.36 k
End timestamp: 1736943941 (2025-01-15T12:25:41.000Z)


MODE 👇
Backfill start time: 13/11/2024
NO METHODOLOGY SPECIFIED
Daily volume: 1.11 M
Daily fees: 1.06 k
Daily revenue: 1.06 k
Daily holders revenue: 1.06 k
End timestamp: 1736943941 (2025-01-15T12:25:41.000Z)


LISK 👇
Backfill start time: 13/11/2024
NO METHODOLOGY SPECIFIED
Daily volume: 81.93 k
Daily fees: 189
Daily revenue: 189
Daily holders revenue: 189
End timestamp: 1736943941 (2025-01-15T12:25:41.000Z)


FRAXTAL 👇
Backfill start time: 19/11/2024
NO METHODOLOGY SPECIFIED
Daily volume: 435.19 k
Daily fees: 437
Daily revenue: 437
Daily holders revenue: 437
End timestamp: 1736943941 (2025-01-15T12:25:41.000Z)

@llamabutler
Copy link

The velodrome-v2 adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts dexs velodrome-v2

🦙 Running VELODROME-V2 adapter 🦙
---------------------------------------------------
Start Date:	Tue, 14 Jan 2025 12:27:23 GMT
End Date:	Wed, 15 Jan 2025 12:27:23 GMT
---------------------------------------------------

OPTIMISM 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 3.42 M
Daily fees: 6.39 k
End timestamp: 1736944042 (2025-01-15T12:27:22.000Z)


MODE 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 53.37 k
Daily fees: 84
End timestamp: 1736944042 (2025-01-15T12:27:22.000Z)


LISK 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 30.74 k
Daily fees: 92
End timestamp: 1736944042 (2025-01-15T12:27:22.000Z)


FRAXTAL 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 16.41 k
Daily fees: 28
End timestamp: 1736944042 (2025-01-15T12:27:22.000Z)

@llamabutler
Copy link

The velodrome-v2 adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees velodrome-v2

🦙 Running VELODROME-V2 adapter 🦙
---------------------------------------------------
Start Date:	Tue, 14 Jan 2025 12:28:04 GMT
End Date:	Wed, 15 Jan 2025 12:28:04 GMT
---------------------------------------------------

OPTIMISM 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily bribes revenue: 20.76 k
End timestamp: 1736944083 (2025-01-15T12:28:03.000Z)


MODE 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily bribes revenue: 1.33 k
End timestamp: 1736944083 (2025-01-15T12:28:03.000Z)


BOB 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily bribes revenue: 0
End timestamp: 1736944083 (2025-01-15T12:28:03.000Z)


LISK 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily bribes revenue: 0
End timestamp: 1736944083 (2025-01-15T12:28:03.000Z)


FRAXTAL 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily bribes revenue: 0
End timestamp: 1736944083 (2025-01-15T12:28:03.000Z)

dtmkeng
dtmkeng requested changes Jan 16, 2025
View reviewed changes
fees/velodrome-v2/index.ts
})
return {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why return only dailyBribes ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that the other metrics were already returned in dexs. Should I add back dailyFees dailyRevenue and dailyHoldersRevenue here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we track by adapter if you remove velodrome v2 is can't show fees

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it back

@dtmkeng dtmkeng self-assigned this Jan 16, 2025
@llamabutler
Copy link

The velodrome-slipstream adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts dexs velodrome-slipstream

🦙 Running VELODROME-SLIPSTREAM adapter 🦙
---------------------------------------------------
Start Date:	Wed, 15 Jan 2025 23:30:11 GMT
End Date:	Thu, 16 Jan 2025 23:30:11 GMT
---------------------------------------------------

OPTIMISM 👇
Backfill start time: 6/3/2024
NO METHODOLOGY SPECIFIED
Daily volume: 81.55 M
Daily fees: 41.00 k
Daily revenue: 41.00 k
Daily holders revenue: 41.00 k
End timestamp: 1737070210 (2025-01-16T23:30:10.000Z)


MODE 👇
Backfill start time: 13/11/2024
NO METHODOLOGY SPECIFIED
Daily volume: 2.52 M
Daily fees: 2.18 k
Daily revenue: 2.18 k
Daily holders revenue: 2.18 k
End timestamp: 1737070210 (2025-01-16T23:30:10.000Z)


LISK 👇
Backfill start time: 13/11/2024
NO METHODOLOGY SPECIFIED
Daily volume: 277.45 k
Daily fees: 342
Daily revenue: 342
Daily holders revenue: 342
End timestamp: 1737070210 (2025-01-16T23:30:10.000Z)


FRAXTAL 👇
Backfill start time: 19/11/2024
NO METHODOLOGY SPECIFIED
Daily volume: 948.16 k
Daily fees: 407
Daily revenue: 407
Daily holders revenue: 407
End timestamp: 1737070210 (2025-01-16T23:30:10.000Z)

@llamabutler
Copy link

The velodrome-v2 adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts dexs velodrome-v2

🦙 Running VELODROME-V2 adapter 🦙
---------------------------------------------------
Start Date:	Wed, 15 Jan 2025 23:31:47 GMT
End Date:	Thu, 16 Jan 2025 23:31:47 GMT
---------------------------------------------------

OPTIMISM 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 2.86 M
Daily fees: 3.80 k
End timestamp: 1737070306 (2025-01-16T23:31:46.000Z)


MODE 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 164.59 k
Daily fees: 217
End timestamp: 1737070306 (2025-01-16T23:31:46.000Z)


LISK 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 33.13 k
Daily fees: 99
End timestamp: 1737070306 (2025-01-16T23:31:46.000Z)


FRAXTAL 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily volume: 33.55 k
Daily fees: 25
End timestamp: 1737070306 (2025-01-16T23:31:46.000Z)

@llamabutler
Copy link

The velodrome-v2 adapter exports:

> adapters@1.0.0 test
> ts-node --transpile-only cli/testAdapter.ts fees velodrome-v2

🦙 Running VELODROME-V2 adapter 🦙
---------------------------------------------------
Start Date:	Wed, 15 Jan 2025 23:32:42 GMT
End Date:	Thu, 16 Jan 2025 23:32:42 GMT
---------------------------------------------------

OPTIMISM 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily fees: 4.46 k
Daily revenue: 4.46 k
Daily holders revenue: 4.46 k
Daily bribes revenue: 617
End timestamp: 1737070361 (2025-01-16T23:32:41.000Z)


MODE 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
Daily holders revenue: 0
Daily bribes revenue: 583
End timestamp: 1737070361 (2025-01-16T23:32:41.000Z)


BOB 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily fees: 10
Daily revenue: 10
Daily holders revenue: 10
Daily bribes revenue: 193
End timestamp: 1737070361 (2025-01-16T23:32:41.000Z)


LISK 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
Daily holders revenue: 0
Daily bribes revenue: 0
End timestamp: 1737070361 (2025-01-16T23:32:41.000Z)


FRAXTAL 👇
Backfill start time not defined
NO METHODOLOGY SPECIFIED
Daily fees: 0
Daily revenue: 0
Daily holders revenue: 0
Daily bribes revenue: 18.67 k
End timestamp: 1737070361 (2025-01-16T23:32:41.000Z)

@dtmkeng dtmkeng merged commit 05b7912 into DefiLlama:master Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtmkeng dtmkeng dtmkeng requested changes

Assignees

@dtmkeng dtmkeng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethzoomer @llamabutler @dtmkeng