Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextToRank should accept interface instead of ParsedSentence as struct #8

Open
koushki opened this issue Mar 4, 2019 · 0 comments
Open

TextToRank should accept interface instead of ParsedSentence as struct #8

koushki opened this issue Mar 4, 2019 · 0 comments

Comments

@koushki
Copy link

koushki commented Mar 4, 2019

If I want to use convert.TextToRank and I have a customized rule, it is not possible to use convert package because it accepts parse.ParsedSentence struct as the first argument.

I had a quick look and it seems should be possible to change parse.ParsedSentence to an interface.

I can create a PR if it does make sense to you @DavidBelicza!
@koushki koushki changed the title TextToRank should accept interface instead of ParsedSentence TextToRank should accept interface instead of ParsedSentence as struct Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@koushki