Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card: add Table for SwitchPT #3556

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Card: add Table for SwitchPT #3556

wants to merge 5 commits into from

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jul 29, 2023 •
edited
Loading

Closes #3555

  • remove Hidden Keyword CARDNAME's power and toughness are switched
  • Extend the AI to check when to use that Ability
  • Technically it should be its own layer, but we don't have a static ability for this?

AI cases:

  • In case of Attacking or Blocking to check if switched PT would be more in favor?
  • Use it as kill Spell if Creature has more damage than power or if power is negative? Need to calculate the right amount of PT after switch
  • AI probably need to respect isSwitchPT when checking for effects like +P/+T or -P/-T ... especially if its like +X/-X or vise versa

@Hanmac Hanmac added Game Mechanics AI General AI tag labels Jul 29, 2023
@Hanmac Hanmac requested review from tool4ever and Agetian July 29, 2023 10:28
@Hanmac Hanmac self-assigned this Jul 29, 2023
@Agetian
Copy link
Contributor

Agetian commented Jul 30, 2023

Sounds like a really good change! I agree that some extra modifications to the AI would be nice, I might take a look at it but slightly later :/

@Hanmac
Copy link
Contributor Author

Hanmac commented Aug 6, 2023

i added first logic part for target SwitchPT to kill opponent creatures

but i hadn't time to test it yet

@Hanmac Hanmac force-pushed the switchedPT branch 2 times, most recently from b90cb04 to 840d078 Compare August 15, 2023 05:12
@github-actions
Copy link

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

@Hanmac Hanmac added keep no stale and removed no-pr-activity labels Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tool4ever tool4ever Awaiting requested review from tool4ever

@Agetian Agetian Awaiting requested review from Agetian

At least 1 approving review is required to merge this pull request.

Assignees

@Hanmac Hanmac

Labels
AI General AI tag Game Mechanics keep no stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch PT as better Pump Effect
2 participants
@Hanmac @Agetian