Release 3.2.2 - reverting breaking changes and marking 3.2.1/3.2.0 as…

… [BROKEN] (nfl#199) * Release 3.2.2 - reverting breaking changes and marking 3.2.1/3.2.0 as [BROKEN] * Changing to 3.2.2 to help users who might be targeting in package.json as `~3.2.x`
CRGavrila · Nov 7, 2016 · fef27eb · fef27eb
1 parent de5a4cf
commit fef27eb
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,8 +2,9 @@
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
 **Table of Contents**  *generated with [DocToc](https://github.com/thlorenz/doctoc)*
 
-- [3.2.1](#321)
-- [3.2.0](#320)
+- [3.2.2](#322)
+- [3.2.1 [BROKEN]](#321-broken)
+- [3.2.0 [BROKEN]](#320-broken)
 - [3.1.0](#310)
 - [3.0.2](#302)
 - [3.0.1](#301)
@@ -24,13 +25,20 @@
 - [1.0.0](#100)
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
-## 3.2.1
+## 3.2.2
+
+Bugfixes:
+
+  - Removed breaking changes `jsnext:main` and `module` from package.json. `es` version required special babel configuration for end users and needs to be re-thought for major release.
+  - Reverted `canUseDOM` setter in `Helmet.js`, as this was a breaking change for some users.
+
+## 3.2.1 [BROKEN]
 
 Bugfixes:
 
   - Removing "engines" field in package.json.
 
-## 3.2.0
+## 3.2.0 [BROKEN]
 
 Features:
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "react-helmet",
   "description": "A document head manager for React",
-  "version": "3.2.1",
+  "version": "3.2.2",
   "main": "./lib/Helmet.js",
   "author": "NFL <engineers@nfl.com>",
   "contributors": [

diff --git a/src/Helmet.js b/src/Helmet.js
@@ -415,7 +415,7 @@ const Helmet = (Component) => {
             return mappedState;
         }
 
-        static setCanUseDOM = canUseDOM => {
+        static set canUseDOM(canUseDOM) {
             Component.canUseDOM = canUseDOM;
         }
 

diff --git a/src/test/HelmetTest.js b/src/test/HelmetTest.js
@@ -1332,7 +1332,7 @@ describe("Helmet", () => {
         ].join("");
 
         before(() => {
-            Helmet.setCanUseDOM(false);
+            Helmet.canUseDOM = false;
         });
 
         it("will html encode title", () => {
@@ -1865,7 +1865,7 @@ describe("Helmet", () => {
                 .that.equals(`<script ${HELMET_ATTRIBUTE}="true" src="foo.js" async></script>`);
         });
         after(() => {
-            Helmet.setCanUseDOM(true);
+            Helmet.canUseDOM = true;
         });
     });
 
@@ -1892,9 +1892,9 @@ describe("Helmet", () => {
             );
 
             expect(Helmet.peek().title).to.be.equal("Fancy title");
-            Helmet.setCanUseDOM(false);
+            Helmet.canUseDOM = false;
             expect(Helmet.peek().title).to.be.equal("Fancy title");
-            Helmet.setCanUseDOM(true);
+            Helmet.canUseDOM = true;
         });
 
         it("will html encode string", () => {