Moving eslint configuration to it's own eslintrc. Updating eslint and…

… relevant dependencies. (nfl#211)
CRGavrila · Dec 4, 2016 · f415315 · f415315
1 parent f25a7a9
commit f415315
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 20 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -0,0 +1,12 @@
+{
+    "extends": "nfl",
+    "env": {
+        "browser": true,
+        "mocha": true,
+        "es6": true
+    },
+    "globals": {
+        "expect": false,
+        "sinon": false
+    }
+}
diff --git a/package.json b/package.json
@@ -40,12 +40,12 @@
     "babel-preset-stage-0": "6.16.0",
     "chai": "3.5.0",
     "cross-env": "3.0.0",
-    "eslint": "3.6.1",
-    "eslint-config-nfl": "10.0.0",
+    "eslint": "3.11.1",
+    "eslint-config-nfl": "11.0.0",
     "eslint-plugin-import": "1.16.0",
-    "eslint-plugin-jsx-a11y": "2.2.2",
-    "eslint-plugin-mocha": "4.5.1",
-    "eslint-plugin-react": "6.3.0",
+    "eslint-plugin-jsx-a11y": "3.0.1",
+    "eslint-plugin-mocha": "4.7.0",
+    "eslint-plugin-react": "6.7.1",
     "estraverse": "4.2.0",
     "estraverse-fb": "1.3.1",
     "isparta-loader": "2.0.0",
@@ -81,19 +81,5 @@
     "compile:commonjs": "cross-env BABEL_ENV=commonjs babel src --out-dir lib",
     "compile:es": "cross-env BABEL_ENV=es babel src --out-dir es --ignore test.js",
     "prepublish": "npm run compile"
-  },
-  "eslintConfig": {
-    "extends": [
-      "nfl"
-    ],
-    "env": {
-      "browser": true,
-      "mocha": true,
-      "es6": true
-    },
-    "globals": {
-      "expect": false,
-      "sinon": false
-    }
   }
 }
diff --git a/src/test/HelmetTest.js b/src/test/HelmetTest.js
@@ -1875,7 +1875,7 @@ describe("Helmet", () => {
             expect(attrs).to.exist;
 
             const markup = ReactServer.renderToStaticMarkup(
-                <html {...attrs} />
+                <html lang="en" {...attrs} />
             );
 
             expect(markup)