(fix) fail gracefully if prop is not an Array and issue warning (nfl#233

) * (fix) fail gracefully if prop is not an Array and issue warning * (lint) remove console log
CRGavrila · Feb 10, 2017 · 9393ba2 · 9393ba2
1 parent 79403c7
commit 9393ba2
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/src/Helmet.js b/src/Helmet.js
@@ -86,7 +86,15 @@ const getTagsFromPropsList = (tagName, primaryAttributes, propsList) => {
     const approvedSeenTags = {};
 
     return propsList
-        .filter(props => typeof props[tagName] !== "undefined")
+        .filter((props) => {
+            if (Array.isArray(props[tagName])) {
+                return true;
+            }
+            if (typeof props[tagName] !== "undefined") {
+                warn(`Helmet: ${tagName} should be of type "Array". Instead found type "${typeof props[tagName]}"`);
+            }
+            return false;
+        })
         .map(props => props[tagName])
         .reverse()
         .reduce((approvedTags, instanceTags) => {
@@ -465,6 +473,10 @@ const handleClientStateChange = (newState) => {
     onChangeClientState(newState, addedTags, removedTags);
 };
 
+const warn = (msg) => {
+    return console && typeof console.warn === "function" && console.warn(msg);
+};
+
 const NullComponent = () => null;
 
 const HelmetSideEffects = withSideEffect(

diff --git a/src/test/HelmetTest.js b/src/test/HelmetTest.js
@@ -870,6 +870,19 @@ describe("Helmet", () => {
                 const existingTags = Array.prototype.slice.call(tagNodes);
                 expect(existingTags).to.be.empty;
             });
+
+            it("fails gracefully when meta is wrong shape", () => {
+                ReactDOM.render(
+                    <Helmet
+                        meta={{"name": "title", "content": "some title"}}
+                    />,
+                    container
+                );
+
+                const tagNodes = headElement.querySelectorAll(`meta[${HELMET_ATTRIBUTE}]`);
+                const existingTags = Array.prototype.slice.call(tagNodes);
+                expect(existingTags).to.be.empty;
+            });
         });
 
         describe("link tags", () => {