Fix/revert null component (nfl#227)

* Reverting NullComponent as it's incompatible with React 14. Marking 3.3.1 as broken, bumping to 3.3.2 * updated doctoc for CHANGELOG
CRGavrila · Jan 17, 2017 · 86933c3 · 86933c3
1 parent d4e7c1d
commit 86933c3
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,7 +2,8 @@
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
 **Table of Contents**  *generated with [DocToc](https://github.com/thlorenz/doctoc)*
 
-- [3.3.1](#331)
+- [3.3.2](#332)
+- [3.3.1 [BROKEN]](#331-broken)
 - [3.3.0](#330)
 - [3.2.3](#323)
 - [3.2.2](#322)
@@ -28,7 +29,13 @@
 - [1.0.0](#100)
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
-## 3.3.1
+## 3.3.2
+
+Bugfixes:
+
+  - Removed stateless functional component `NullComponent` because of it's incompatibility with React 14 and reverted back to PlainComponent.
+
+## 3.3.1 [BROKEN]
 
 Bugfixes:
 

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "react-helmet",
   "description": "A document head manager for React",
-  "version": "3.3.1",
+  "version": "3.3.2",
   "main": "./lib/Helmet.js",
   "author": "NFL <engineers@nfl.com>",
   "contributors": [

diff --git a/src/Helmet.js b/src/Helmet.js
@@ -7,6 +7,7 @@ import {
     TAG_PROPERTIES,
     REACT_TAG_MAP
 } from "./HelmetConstants.js";
+import PlainComponent from "./PlainComponent";
 
 const HELMET_ATTRIBUTE = "data-react-helmet";
 
@@ -465,12 +466,10 @@ const handleClientStateChange = (newState) => {
     onChangeClientState(newState, addedTags, removedTags);
 };
 
-const NullComponent = () => null;
-
 const HelmetSideEffects = withSideEffect(
     reducePropsToState,
     handleClientStateChange,
     mapStateOnServer
-)(NullComponent);
+)(PlainComponent);
 
 export default Helmet(HelmetSideEffects);
diff --git a/src/PlainComponent.js b/src/PlainComponent.js
@@ -0,0 +1,7 @@
+import React from "react";
+
+export default class PlainComponent extends React.Component {
+    render() {
+        return null;
+    }
+}