Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit compliance #95

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Pre-commit compliance #95

merged 1 commit into from
Jan 13, 2025

Conversation

swo
Copy link
Collaborator

@swo swo commented Jan 13, 2025

  • Add some NotImplementedErrors; I wasn't systematic about this
  • Comment out code that doesn't actually function, but we want to use as a skeleton
  • Ensure pre-commit passes

@swo swo requested a review from Fuhan-Yang January 13, 2025 19:02
@swo swo mentioned this pull request Jan 13, 2025
Open
Fuhan-Yang
Fuhan-Yang approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Fuhan-Yang Fuhan-Yang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Interestingly commenting the code didn't raise pre-commit error. I have the experiences that pre-commit complained about the unused commented code, not sure if it was black.

@swo swo merged commit 2f9e61d into fy_config_preprocess Jan 13, 2025
2 checks passed
@swo swo deleted the fy_config_preprocess_swo branch January 13, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fuhan-Yang Fuhan-Yang Fuhan-Yang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swo @Fuhan-Yang