Adding support for bitwise negation and XOR operators and for bitwise AND, XOR, and OR compound assignments #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d assignment by bitwise AND, XOR, and OR
src/blocks/expr.cpp
Outdated
| @@ -54,6 +59,12 @@ void bitwise_or_expr::dump(std::ostream &oss, int indent) { | |||
| expr1->dump(oss, indent + 1); | |||
| expr2->dump(oss, indent + 1); | |||
| } | |||
| void bitwise_xor_expr::dump(std::ostream &oss, int indent) { | |||
| printer::indent(oss, indent); | |||
| oss << "BITWISE_xOR_EXPR" << std::endl; | |||
There was a problem hiding this comment.
Minor NIT, but let's fix capitalization here
There was a problem hiding this comment.
Thank you for spotting the typo! I fixed it.
AjayBrahmakshatriya
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bitwise operators are essential for many low-level, high-performance operations, such as checksum or hashing. Thus, covering the complete set of bitwise operators can improve Build-it's capability. At the same time, compound assignments can increase the code readability when using these operators.
This patch adds the unary bitwise negation operator (i.e., ~) and the binary bitwise XOR operator support (i.e., ^). Moreover, it adds support for compound assignments for the bitwise AND, XOR, and OR operators (i.e., &=, ^=, |=, respectively).