Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binance unrecognised transactions #347

Open
crashnick16 opened this issue Mar 2, 2024 · 9 comments
Open

binance unrecognised transactions #347

crashnick16 opened this issue Mar 2, 2024 · 9 comments
Assignees
Labels
data file update Correction to an existing data file format

Comments

@crashnick16
Copy link

hey there, just run a report and a number of binance transactions are not recognised at all

ERROR Unrecognised Account: 'Isolated Margin'
row[492] ['63265734', '2021-03-23 18:40:40', 'Isolated Margin', 'Transfer Between Main Account/Futures and Margin Account', 'THETA', '-0.69930000', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[493] ['63265734', '2021-03-23 18:40:40', 'Spot', 'Transfer Between Main Account/Futures and Margin Account', 'THETA', '0.69930000', '']
ERROR Unrecognised Operation: 'Transfer Between Main Account/Futures and Margin Account'
row[494] ['63265734', '2021-03-23 18:43:46', 'Isolated Margin', 'Transfer Between Main Account/Futures a
nd Margin Account', 'USDT', '-129.24083344', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[495] ['63265734', '2021-03-23 18:43:46', 'Spot', 'Transfer Between Main Account/Futures and Margin Account', 'USDT', '129.24083344', '']
ERROR Unrecognised Operation: 'Transfer Between Main Account/Futures and Margin Account'
row[2091] ['63265734', '2021-06-26 09:33:44', 'Spot', 'Transaction Fee', 'BNB', '-0.00038165', '']
ERROR Unrecognised Operation: 'Transaction Fee'

@crashnick16
Copy link
Author

row[2806] ['63265734', '2021-12-04 18:27:41', 'Spot', 'Transfer Between Spot Account and UM Futures Account', 'USDT', '-643.55370000', '']
ERROR Unrecognised Operation: 'Transfer Between Spot Account and UM Futures Account'

@crashnick16
Copy link
Author

ERROR Unrecognised Account: 'USD-M Futures'
row[2816] ['63265734', '2021-12-04 18:44:23', 'USD-M Futures', 'Realized Profit and Loss', 'USDT', '0.40230000', '']
ERROR Unrecognised Account: 'USD-M Futures'
row[2817] ['63265734', '2021-12-04 18:44:23', 'USD-M Futures', 'Fee', 'USDT', '-0.36181760', '']
ERROR Unrecognised Account: 'USD-M Futures'
row[2818] ['63265734', '2021-12-04 18:44:23', 'USD-M Futures', 'Realized Profit and Loss', 'USDT', '0.37799999', '']
ERROR Unrecognised Account: 'USD-M Futures'
row[2819] ['63265734', '2021-12-04 18:44:23', 'USD-M Futures', 'Fee', 'USDT', '-0.78266700', '']
ERROR Unrecognised Account: 'USD-M Futures'
row[2820] ['63265734', '2021-12-04 18:44:23', 'USD-M Futures', 'Fee', 'USDT', '-0.42478560', '']

@crashnick16
Copy link
Author

ERROR Unrecognised Operation: 'Transaction Fee'
row[4497] ['63265734', '2023-09-22 02:52:57', 'Spot', 'Airdrop Assets', 'LUNA', '0.72469000', '']
ERROR Unrecognised Operation: 'Airdrop Assets'
row[4498] ['63265734', '2023-10-20 09:30:39', 'Spot', 'Airdrop Assets', 'LUNA', '0.72469000', '']
ERROR Unrecognised Operation: 'Airdrop Assets'
row[4499] ['63265734', '2023-11-17 09:02:56', 'Spot', 'Airdrop Assets', 'LUNA', '0.72469000', '']

@nanonano nanonano self-assigned this Mar 4, 2024
@nanonano nanonano added the data file update Correction to an existing data file format label Mar 4, 2024
@nanonano
Copy link
Member

nanonano commented Mar 4, 2024

Hi @crashnick16, I'm in the process of adding support for futures/margin trading here: https://github.com/BittyTax/BittyTax/tree/features/margin-trading.

Are you able to provide some examples exports files for these?

Also, please can you re-test using the latest "unreleased" version from GitHub, as I think some of these other Unrecognised Operation Errors are already fixed.

@nanonano
Copy link
Member

nanonano commented Mar 6, 2024

I've pushed some updates to the features/margin-trading branch to support Binance futures, please give it a test.

@crashnick16
Copy link
Author

I've pushed some updates to the features/margin-trading branch to support Binance futures, please give it a test.

I have done some testing and here are the errors I still get:

file: binance_statement_2021-01-01_2022-01-01.csv matched as "Binance Statements"
WARNING Parser failure for "Binance Statements"
row[488] ['63265734', '2021-03-23 18:23:25', 'Isolated Margin', 'Transfer Between Main Account/Futures and Margin Account', 'USDT', '139.11083344', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[489] ['63265734', '2021-03-23 18:30:13', 'Isolated Margin', 'Fee', 'THETA', '-0.00070000', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[490] ['63265734', '2021-03-23 18:30:13', 'Isolated Margin', 'Sell', 'USDT', '-9.87000000', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[491] ['63265734', '2021-03-23 18:30:13', 'Isolated Margin', 'Buy', 'THETA', '0.70000000', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[492] ['63265734', '2021-03-23 18:40:40', 'Isolated Margin', 'Transfer Between Main Account/Futures and Margin Account', 'THETA', '-0.69930000', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[494] ['63265734', '2021-03-23 18:43:46', 'Isolated Margin', 'Transfer Between Main Account/Futures and Margin Account', 'USDT', '-129.24083344', '']
ERROR Unrecognised Account: 'Isolated Margin'
row[2792] ['63265734', '2021-12-04 15:09:59', 'Funding', 'Transfer Between Main and Funding Wallet', 'BTC', '0.05000000', '']
ERROR Unrecognised Account: 'Funding'
row[2793] ['63265734', '2021-12-04 15:09:59', 'Spot', 'Transfer Between Main and Funding Wallet', 'BTC', '-0.05000000', '']
ERROR Unrecognised Operation: 'Transfer Between Main and Funding Wallet'
row[2794] ['63265734', '2021-12-04 15:19:31', 'Funding', 'Transfer Between Main and Funding Wallet', 'BTC', '-0.05000000', '']
ERROR Unrecognised Account: 'Funding'
row[2795] ['63265734', '2021-12-04 15:19:31', 'Spot', 'Transfer Between Main and Funding Wallet', 'BTC', '0.05000000', '']
ERROR Unrecognised Operation: 'Transfer Between Main and Funding Wallet'
file: binance_statement_2022-01-01_2023-01-01.csv matched as "Binance Statements"
WARNING Parser failure for "Binance Statements"
row[1740] ['63265734', '2022-05-28 14:59:17', 'Spot', 'Token Swap - Redenomination/Rebranding', 'LUNC', '99168.02300718', '']
ERROR Unrecognised Operation: 'Token Swap - Redenomination/Rebranding'
row[1741] ['63265734', '2022-05-28 14:59:17', 'Spot', 'Token Swap - Redenomination/Rebranding', 'LUNA', '-99168.02300718', '']
ERROR Unrecognised Operation: 'Token Swap - Redenomination/Rebranding'
WARNING Duplicate rows detected for "Binance Statements", use the [--duplicates] option to remove them (use with care)

@nanonano
Copy link
Member

Hi @crashnick16, thanks for testing, see there's been some improvement.

I need to implement handling for the "Isolated Margin" and "Funding" wallets, are you able to provide an example CSV with these, either email me privately or obfuscate anything personal.

Does Binance provide an export for Isolated Margin trading which contains the realised profits or loss? Otherwise it will need to be calculated manually, which I'm not sure how to do, can you explain what calculations are required?

"Token Swap - Redenomination/Rebranding" this operation is dependant on this fix #320. You could manually change them to be an Airdrop followed by a Spend.

@nanonano
Copy link
Member

As there are issues implementing Swap see #320. I've implemented the 'Token Swap - Redenomination/Rebranding' operation as an Airdrop, following by a Spend in the interim, see 9513c29.

@nanonano
Copy link
Member

With the merging of the margin trading branch into master, all these unrecognised Account/Operation errors should be fixed now.

Please re-test and let me know if you have any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data file update Correction to an existing data file format
Projects
None yet
Development

No branches or pull requests

2 participants