-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart Library: Responsive Charts #40922
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
c822127
to
dc2c72e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! It works as described and looks good!
I made a small tweak to allow responsive to fallback to fixed size, so that it wouldn't break the usage with explicit width and height.
Plus updated a couple of stories as well, and we should probably need more storied added for responsiveness.
Proposed changes:
visx/responsive
in a HOC wrapper to make them responsiveOther information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Run
pnpm install
as dependencies have been addedIn your Jetpack local env, navigate to the Storybook development environment:
Find
JS Packages/Charts/Bar Chartl
in the sidebarVerify the chart is responsive when you use the handles on the container to resize the chart container.
Find
JS Packages/Charts/Pie Chart
in the sidebar