I havent change anythig in plugin, just change manifest version from 4 to 5 in manifest.json
Then there is javascript error in debugger console in photoshop plugin. And plugin is not working.
I think manifest 4 is very old, there is lot of new functionality working only on 5 version, so would be nice if examples would work in manifest 5, to make a kind of boilerplate for plugins, in other case they are not very useful now .
Edit:
"network": {
"allowCodeGenerationFromStrings": true
},
is fixing it, but i think this is not super secure