Early Bird Registration for DrupalCon Atlanta is now open! By registering during our Early Bird Registration window, you’ll save $100. This window ends on 19 January 2025 and will go by quickly, so don’t wait!Problem/Motivation
When testing at core 10.2 we get
Passing null to the $typedConfigManager parameter of ConfigFormBase::__construct() is deprecated in drupal:10.2.0 and must be an instance of \Drupal\Core\Config\TypedConfigManagerInterface in drupal:11.0.0.
See https://www.drupal.org/node/3404140
Change record https://www.drupal.org/node/3404140
The tests fail at 8.x-1.x because drupalCI.yml has suppress-deprecations: false
The 2.x branch does not fail, but only because it has suppress-deprecations: true, added recently because of #3413015: Tests fail with "Using a translatable string as a category for field type is deprecated"
Issue fork scheduler-3417444
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedTesting on 8.x-1.x first because that branch is not affected by the 3rd-party deprecations for Address and Commerce #3413015: Tests fail with "Using a translatable string as a category for field type is deprecated" so it is easier to see if the actual $typedConfigManager deprecation has been fixed.
The CronForm is fixed by the first commit. Gitlab pipeline for 'next minor' did fail for @group "scheduler"
https://git.drupalcode.org/project/scheduler/-/jobs/701379
But now it passes
https://git.drupalcode.org/project/scheduler/-/jobs/701515
Unfortunately the deprecation for AdminForm that we see on Scheduler 2.x is not produced by the tests at 8.x-1.x
On DrupalCI the test failures reduced from 4 to 3. The three failiures are deprecations in Rules tests, regarding how the rules config is created. This is probably something in Rules, not under our control.
Comment #8
jonathan1055 CreditAttribution: jonathan1055 as a volunteer commentedFixed in 2.x and 8.x-1.x
The deprecations are suppressed now in both branches on DrupalCI, due to the deprecations in other modules making it look like this module is failing.
In the gitlab pipeline, the phpunit running current core has no override for variable
SYMFONY_DEPRECATIONS_HELPERso it defaults to 'weak' and hides all deprecations.But now we also have the option to run phpunit at the next minor core version (which is currently the same 10.2.3-dev as in the current core (but will be updated to 10.3 dev). These tests do not have deprecations suppressed so we can see everything that needs attention.