Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Issue fork subrequests-3434821
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot CreditAttribution: project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.
Therefore these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #7
rajeshreeputraAs of PHP 8.3 the function assert_options() and the assert.* directives are deprecated and should not be used in production code. To enable assertions PHP should be configured with zend.assertions.
Looking for alternative meanwhile requesting opinion from maintainer and community for the same.
Comment #8
rajeshreeputraComment #9
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedApart from this deprecation https://git.drupalcode.org/issue/subrequests-3434821/-/jobs/1762586#L45, changes looks fine and can be merged as PHPunit pipelines are passing for all, hence moving into RTBC
Comment #10
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedComment #12
project update bot CreditAttribution: project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module, even with these changes, this module is not yet compatible with Drupal 11.
Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.
Therefore, these changes did not update the
info.yml
file for Drupal 11 compatibility.The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.
Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #14
vipin.mittal18MR !30 makes this module D11 compatible.
Comment #15
japerryI'd probably go back the original bot and re-run the scans. The merging of linting and deprecations makes it hard to understand what could be a breaking change downstream. It also removed Drupal 9.5 compatibility, which doesn't seem necessary.
Comment #16
japerryTested both in gitlabci as well as locally on D9.5, 10, and 11.. all tests passing and is looking good to commit, pending one more minor change from ankitv18
Comment #17
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedJuggling between the defined and version_compare to handle the BC for MASTER and MAIN request constant.
I'm going with the version_compare and defined will throw exception and also need additional check of version_compare to handle the proper BC.
So I believe version_compare is the good way to move forward.
Comment #18
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedComment #19
deepakkm CreditAttribution: deepakkm at Acquia commentedThis is good to release, verified locally and its working fine.
Comment #22
phenaproximaReviewed. I can see that 99% of the changes here are to comply with the coding standards. That leads to a lot of useless comments, but if it gets the pipelines passing, so be it; we can always improve them later. I think it's more important to get Subrequests released for Drupal 11!
Comment #23
phenaproximaComment #25
phenaproxima