Problem/Motivation

Remove the: default_argument_skip_url contextual filter setting from the view: views.view.scheduler_scheduled_content.yml configuration as it has been removed from the Drupal Core 10.2.x. If it's not removed, it's causing PHPUnit tests to fail in Drupal 11

Change record: The Views setting default_argument_skip_url has been removed

Issue: #981870: Skip default argument for view URL does not work and never has so it can be removed

Steps to reproduce

Run the PHPUnit tests for Drupal 11 and you'll see all tests failing.

Proposed resolution

Remove the setting: default_argument_skip_url: false from view views.view.scheduler_scheduled_content.yml. I believe no update hook will be required as it would taken care by Drupal Core itself.

Issue fork scheduler-3463136

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vishalkhode created an issue. See original summary.

vishalkhode’s picture

vishalkhode CreditAttribution: vishalkhode as a volunteer and at Acquia commented
Issue summary: View changes

vishalkhode opened merge request !155

vishalkhode’s picture

vishalkhode CreditAttribution: vishalkhode as a volunteer and at Acquia commented
Assigned: vishalkhode » Unassigned
Status: Active » Needs review
deepakkm’s picture

deepakkm CreditAttribution: deepakkm at Acquia commented
Status: Needs review » Reviewed & tested by the community
jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Related issues: -#3434325: Drupal 11 compatibility fixes [2.x]

I have re-based this MR now that #3463494: Gitlab PHPunit jobs at D11 need compatible test dependencies is merged.

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Status: Reviewed & tested by the community » Fixed

Previously every PHPunit test contain

Schema errors for views.view.scheduler_scheduled_content with the following errors:
views.view.scheduler_scheduled_content:display.user_page.display_options.arguments.uid.default_argument_skip_url
missing schema

With this MR, those errors are removed.

Thank you @vishalkhode. Merged and fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

jonathan1055 opened merge request !165

jonathan1055’s picture

jonathan1055 CreditAttribution: jonathan1055 as a volunteer commented
Status: Closed (fixed) » Fixed

Backported to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.