Problem/Motivation

When making a MR, the drupal CI pipeline has "errors" with regard to coding style remaining in PHP, CSS, and JS. The spelling issues have been resolved. While this does not affect the performance of Radix, it would be nice to have them all pass if possible. Super low priority.

Issue fork radix-3500012

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

danchadwick created an issue. See original summary.

danchadwick’s picture

Notable changes:

The (presumably intended to be private) global function radixCleanIdentifier was changed to snake-case radix_clean_identifier. It is not expected that subthemes would call this function. However, if they do, they would need to update the function call accordingly.

The drush command radix:create had it annotation corrected to remove the machine_name option, which is not implemented.

Furthermore, the drush documentation indicates that PHP 8+ only commands should be written with PHP attributes. This would be a separate issue. The annotation would be something like:

use Drush\Attributes as CLI;
[snip]
/**
 * Create a radix sub-theme.
 */
#[CLI\Command(name: 'radix:create', aliases: ['radix'])]
#[CLI\Argument(name: 'name', description: 'The machine-readable name of your sub-theme.')]
#[CLI\Usage(name: 'drush radix:create my-theme', description: 'Creates a Radix sub-theme called my_theme, using the radix_starterkit.')]

  • danchadwick committed 076ad8d4 on 6.0.x
    Issue #3500012 by danchadwick: Resolve coding style deviations in GitLab...
danchadwick’s picture

Status: Active » Fixed

All CI code-standard test pass now. Some of the eslint ones were made to pass by disabling the tests to avoid coding changes.