Still on Drupal 7? Security support for Drupal 7 ended on 5 January 2025. Please visit our Drupal 7 End of Life resources page to review all of your options.
Problem/Motivation
When making a MR, the drupal CI pipeline has "errors" with regard to coding style remaining in PHP, CSS, and JS. The spelling issues have been resolved. While this does not affect the performance of Radix, it would be nice to have them all pass if possible. Super low priority.
Issue fork radix-3500012
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
danchadwick CreditAttribution: danchadwick as a volunteer commentedNotable changes:
The (presumably intended to be private) global function
radixCleanIdentifier
was changed to snake-caseradix_clean_identifier
. It is not expected that subthemes would call this function. However, if they do, they would need to update the function call accordingly.The drush command
radix:create
had it annotation corrected to remove themachine_name
option, which is not implemented.Furthermore, the drush documentation indicates that PHP 8+ only commands should be written with PHP attributes. This would be a separate issue. The annotation would be something like:
Comment #5
danchadwick CreditAttribution: danchadwick as a volunteer and commentedAll CI code-standard test pass now. Some of the eslint ones were made to pass by disabling the tests to avoid coding changes.