It would be useful to subclass MigrateBatchExecutable in some cases to customize how the batch process is created and executed (for example, overriding MigrateBatchExecutable::calculateBatchLimit).

The class currently has two static references to itself that prevent it from being subclassed/overridden. Changing these to late static bindings improves the extensibility of this class.

CommentFileSizeAuthor
#2 3391697-2.patch909 bytesmediabounds

Issue fork migrate_tools-3391697

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mediabounds created an issue. See original summary.

mediabounds’s picture

mediabounds CreditAttribution: mediabounds at Float commented
Status: Active » Needs review
StatusFileSize
new 3391697-2.patch909 bytes
el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Without this, it's imposibble to override methods without duplicating batchProcessImport, because the methods won't be called.

This patch fixed the issue.

el7cosmos opened merge request !51

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
CreditAttribution: el7cosmos at PreviousNext commented
Status: Reviewed & tested by the community » Needs review

There is another one in batchImport, create and MR with additional change

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Looks good to me

The failing test is present in HEAD - https://www.drupal.org/pift-ci-job/2820117

  • heddn committed 4bb659f7 on 6.0.x authored by mediabounds 
    Issue #3391697 by el7cosmos, mediabounds, larowlan, heddn: Allow...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Status: Reviewed & tested by the community » Fixed

Thanks for this improvement

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.