Still on Drupal 7? Security support for Drupal 7 ended on 5 January 2025. Please visit our Drupal 7 End of Life resources page to review all of your options.Submit button in edit form is not working for forms that have an input with the name "id". This is because form.id is overridden by the element, so the logic in gin_editform.js breaks. I will provide a patch shortly.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3231922-2.patch | 1.59 KB | s.messaris |
Comments
Comment #2
s.messaris CreditAttribution: s.messaris at Web Bunch commentedHere is the patch, using
getAttribute('id')to avoid the problem.Comment #3
s.messaris CreditAttribution: s.messaris at Web Bunch commentedComment #4
s.messaris CreditAttribution: s.messaris at Web Bunch commentedThe implementation that is based on the form id will probably need to be changed, it also doesn't work if the whole form is replaced by ajax, as for example happens in commerce add payment form.
Comment #6
saschaeggiThis is a very good improvement, thanks. We'll refactor the form actions anyway in a next step.
Comment #8
andres.torres CreditAttribution: andres.torres as a volunteer commentedHi All, still not sure if this issue is related to https://www.drupal.org/project/field_group/issues/2969051 but in order to make sure it gets fixed im reporting it also here. Any help is very appreciated.
Comment #9
andres.torres CreditAttribution: andres.torres as a volunteer commentedThe issue is not fixed! Using Claro-Gin under PHP 8X is triggering these errors, lets please work together to fix them on Drupal 9.5+, Since when turning back to Seven there is no issue apparently..
Comment #10
andres.torres CreditAttribution: andres.torres as a volunteer commented