Overview

In #3499791: Errors returned from the publish all endpoint should include the autosave key in the meta we make AutosaveManager::getAutoSaveKey public and passed around the manager for validation

But afterwards I realised it could be static and then we don't need to pass it around.

Proposed resolution

Revert the passing of the auto save manager from #3499791: Errors returned from the publish all endpoint should include the autosave key in the meta and make the method static instead.

User interface changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

larowlan created an issue. See original summary.

larowlan’s picture

Assigned: Unassigned » wim leers
Status: Active » Needs review

I was half expecting Wim would have suggested this overnight too :)

wim leers’s picture

Priority: Normal » Minor
Issue tags: +clean-up

I was half expecting Wim would have suggested this overnight too :)

I did think that originally, actually, but this is in an area that is likely to continue to evolve, so it wasn't worth even having that nitpicky discussion :)

LGTM, but the e2e changes should be reverted.

wim leers’s picture

Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

There's an e2e change in there that I failed to remove 😅

larowlan’s picture

Status: Needs work » Needs review
Issue tags: -Needs reroll
wim leers’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for doing that chore, @larowlan — I'd have done it myself but ran out of time (and steam) yesterday.

wim leers’s picture

Status: Reviewed & tested by the community » Fixed