Still on Drupal 7? Security support for Drupal 7 ended on 5 January 2025. Please visit our Drupal 7 End of Life resources page to review all of your options.
Overview
In #3499791: Errors returned from the publish all endpoint should include the autosave key in the meta we make AutosaveManager::getAutoSaveKey public and passed around the manager for validation
But afterwards I realised it could be static and then we don't need to pass it around.
Proposed resolution
Revert the passing of the auto save manager from #3499791: Errors returned from the publish all endpoint should include the autosave key in the meta and make the method static instead.
User interface changes
Issue fork experience_builder-3500087
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
larowlanI was half expecting Wim would have suggested this overnight too :)
Comment #4
wim leersI did think that originally, actually, but this is in an area that is likely to continue to evolve, so it wasn't worth even having that nitpicky discussion :)
LGTM, but the e2e changes should be reverted.
Comment #5
wim leersComment #6
wim leersThere's an e2e change in there that I failed to remove 😅
Comment #7
larowlanComment #8
wim leersThanks for doing that chore, @larowlan — I'd have done it myself but ran out of time (and steam) yesterday.
Comment #10
wim leers