Problem/Motivation

We recently added the gitlab CI pipeline for code checking.

The code does not pass all the tests.

Steps to reproduce

Check the recent gitlab pipeline run, for the failed tests.

Proposed resolution

Fix all the code styling warning.

CommentFileSizeAuthor
#2 3458116-country-phpcs-cspell.patch7.95 KBnilesh.addweb

Issue fork country-3458116

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

batigolix created an issue. See original summary.

nilesh.addweb’s picture

nilesh.addweb CreditAttribution: nilesh.addweb at AddWeb Solution Pvt. Ltd. for AddWeb Solution Pvt. Ltd. commented
StatusFileSize
new 3458116-country-phpcs-cspell.patch7.95 KB

Hi, I have fixed phpcs and some cspell issue and created patch.

nilesh.addweb opened merge request !16

nilesh.addweb’s picture

nilesh.addweb CreditAttribution: nilesh.addweb at AddWeb Solution Pvt. Ltd. for AddWeb Solution Pvt. Ltd. commented
Status: Active » Needs review

Hi,
In the latest pipeline run, all jobs passed except for PHPStan. The issue is originating from the feeds and facets dependent modules.

before -->https://git.drupalcode.org/issue/country-3444094/-/jobs/2110619
after --> https://git.drupalcode.org/issue/country-3458116/-/jobs/2155178

deepak5423’s picture

deepak5423 CreditAttribution: deepak5423 at Innoraft for Drupal India Association commented
Status: Needs review » Needs work

@nilesh.addweb phpstan test is still failing.
Moving the ticket to NW.

ankitv18 made their first commit to this issue’s fork.

ankitv18’s picture

ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commented
Status: Needs work » Needs review

Now pipelines are executed properly and all jobs are green.

deepak5423’s picture

deepak5423 CreditAttribution: deepak5423 at Innoraft for Drupal India Association commented
Status: Needs review » Reviewed & tested by the community

All the pipelines are passing.
Moving the ticket to RTBC.

batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
CreditAttribution: batigolix at Finalist for Maastricht University commented
batigolix’s picture

batigolix
Primary language Dutch
Location Utrecht
CreditAttribution: batigolix at Finalist commented
Status: Reviewed & tested by the community » Fixed

Thanks everybody for the contributions

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.