Problem/Motivation
Hello project maintainers,
This is an automated issue to help make this module compatible with Drupal 11.
Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.
The changes will be posted by the Project Update Bot official user account. This account will not receive any issue credit contributions for itself or any company.
Proposed resolution
You have a few options for how to use this issue:
- Accept automated changes until this issue is closed
If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.
As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.
Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.
- Leave open but stop new automated changes.
If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.
- Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.
If the issue is reopened, then new automated changes will be posted.
If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.
Remaining tasks
Using the patches
- Apply the latest patch in the comments by Project Update Bot or human contributors that made it better.
- Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.
Using the merge request
- Review the merge request and test it.
- Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
- Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.
Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!
Providing feedback
If there are problems with one of the changes posted by the Project Update Bot, such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue. For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue.
Comment | File | Size | Author |
---|---|---|---|
#10 | consumers.1.x-dev.rector.patch | 2.84 KB | project update bot |
#10 | interdiff-last-bot.6931599.txt | 391 bytes | project update bot |
#5 | consumers.1.x-dev.rector.patch | 2.32 KB | project update bot |
#5 | interdiff-last-bot.6922520.txt | 353 bytes | project update bot |
#4 | consumers.1.x-dev.rector.patch | 1.77 KB | project update bot |
Issue fork consumers-3429497
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
project update bot CreditAttribution: project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug info
This patch was created using these packages:
Comment #4
project update bot CreditAttribution: project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #5
project update bot CreditAttribution: project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #8
vishalkhode CreditAttribution: vishalkhode as a volunteer and at Acquia commentedReviewed changes and looks good to me.
Comment #10
project update bot CreditAttribution: project update bot commentedThis is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.
It is important that any automated tests available are run and that you manually test the changes.
Drupal 11 Compatibility
According to the Upgrade Status module these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the
info.yml
file for Drupal 11 compatibility.Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.
Debug information
These packages were used to generate the fixes:
Comment #12
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedRTBC+!
Comment #13
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedComment #14
vipin.mittal18Hello @joe/ @matheu,
It would be grateful if you update us about your plans to release a pre/stable version of consumers so we can use this in our headless application that supports Drupal 11.
Thanks!
Comment #16
eojthebraveI added some tests for the exception handling. Otherwise I think this looks good.
I'm wondering if when tagging a new release we should switch to something like `2.0.0` instead of `8.x-1.18` since we're dropping support for Drupal 8 with this release and the convention seems to be that you should bump the minor version. But ... since we're still using the old version numbering scheme that doesn't quite work. Anyone have thoughts about version numbering?
Comment #17
deepakkm CreditAttribution: deepakkm at Acquia commentedYes i think we should switch to 2.0.0 as we have dropped support for Drupal 8
Comment #18
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedI would suggest go with 8.x-1.19 (As there aren't many changes) and once decided for minimum support is D10.1 or above then plan for 2.x
Or we can Drop D9 also put minimum support D10.1 and remove conditional statements for watchdog_exception deprecation (In this case we should go with 2.x)
Comment #19
ankitv18 CreditAttribution: ankitv18 as a volunteer and at Acquia commentedAlright @eojthebrave can we plan the release this weekend?
Comment #20
vipin.mittal18The bot has been reinstated in order to prevent multiple tickets(https://www.drupal.org/project/consumers/issues/3459583) from being opened simultaneously.
Comment #21
vipin.mittal18Hello eojthebrave,
You should keep the current naming and go with 8.x-1.18 even if you drop support for Drupal 8. The changes also meet the criteria of a patch version that fixes issues without introducing new functionality.
It would be helpful if you could inform when you intend to release a pre/stable version of consumers as Drupal 11 stable is nearing its release date. Thanks!
Comment #23
eojthebraveThanks everyone. I've merged in the latest changes and I'll get a new release tagged shortly.
Comment #24
eojthebraveComment #25
idebr CreditAttribution: idebr at iO commentedConsidering Drupal 11 has been released a while ago, this issue can now be marked as fixed?
Comment #26
deepakkm CreditAttribution: deepakkm at Acquia commented