Still on Drupal 7? Security support for Drupal 7 ended on 5 January 2025. Please visit our Drupal 7 End of Life resources page to review all of your options.Problem/Motivation
Currently we have a hidden config to enable minor updates
Now that we are on track to be Starshot we should support this out of the box.
We finished #3314143: Add documentation for testing minor updates
Proposed resolution
- Change the default of
allow_core_minor_updatesto true - update tests and add to update path test
Remaining tasks
User interface changes
API changes
Data model changes
| Comment | File | Size | Author |
|---|---|---|---|
| #20 | Captura de tela de 2023-06-28 14-40-13.png | 12.39 KB | lucienchalom |
Issue fork automatic_updates-3324421
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
tedbowComment #3
wim leersDid I misunderstand then that AU would initially only do security updates by default?
Or … I guess this is referring to the fact that minor updates would be possible after enabling this, but never unattended? 🤔
Comment #4
tedbowActually I think a form doesn't make sense. I think anyone who had access to the setting form would also have access to the update form.
In core `allow_core_minor_updates` will likely still be false for MVP. So we would need to update `scripts/src/Converter.php`(we should change this to CoreMergeRequestConvert.php) to change the default back. But I think it would be good if people could start enable do minor updates in the contrib project
So marking this as core-post-mvp because it doesn't have to get done before MVP as we would only convert this back for the merge request
Comment #5
tedbowComment #7
wim leers… does this mean only a subset of this project will go into core as an experimental module, and this project will continue to exist to extend it? 🤔
Comment #8
tedbowautomatic_updates_extensionswill not go into core. I could be wrong but I think when we eventually get extension updates into core will be inautomatic_updates. We only made it an experimental separate module because adding to the main module would have made converting it to a core MR and ripping out extension updating would have been difficult.I have talked with @xjm and she was ok with Core mvp having a hidden config to turn on minor updates. I think it is ok for that config to be turned on in the contrib module. This will allow more users to test that feature which I sure many more people will turn on in core then our whole user base.
Comment #9
tedbowComment #10
wim leers#8: So how will the transition be handled for sites already using
automatic_updates_extensionsin the currentdrupal/automatic_updates? Given that we won't be moving everything into core, we need a transition plan. I'm afraid that is then also missing from #3319030: Drupal Core Roadmap for Automatic Updates.Doesn't the current MR enabling it make the transition of this module into core more difficult? It means that the "convert project to MR" script will need to become more complicated?
What exactly do we gain by enabling a feature in the contrib module by default that AFAICT will definitely not be enabled by default in core? Isn't that setting the wrong expectation for users of the contrib module?
Comment #11
tedbowComment #12
tedbowWe could considering doing this for the 2.x branch but the default value for core will false
Comment #13
wim leersThat would work I guess.
But I think that since #9, the conclusion has changed to "don't do any
contrib-onlythings, only docore-mvpthings", so my concerns in #10 are moot at this point — at least until the time we choose to land this.Comment #14
wim leersMR needs to be re-created on top of
3.0.x.Comment #16
elberHi I just rebased.
Comment #19
lucienchalom CreditAttribution: lucienchalom at CI&T commentedI tryed to copy the changes to a branch from version 3.0.X ingoring the commits from 8.X-2.X
The file tests/src/Functional/UpdatePathTest.php doesn't exist in this branch.
I am not sure about automatic_updates.install because the automatic_updates_update_last_removed points to 9002 and this patch adds 9903.
Please review
Comment #20
lucienchalom CreditAttribution: lucienchalom at CI&T commentedLocally the failed test passes, so I am unable to fix it, sorry.
moving to needs work.
Comment #21
tedbow