-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix site title focus ring #2704
Conversation
🦋 Changeset detectedLatest commit: 8bcbcb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, also tested locally without replacesTitle
or a logo
and it works as expected 👍
Thanks for the quick response @delucis! |
@delucis - Unfortunately, I came across an issue when doing some testing based on this PR. By default, I believe most browsers will apply an When the outline is customized to a larger width, the outline does not display consistently on all borders for I've updated the repro to Starlight v0.30.2 and to use a Note When the viewport is < 1400px, the outline on Another scenario is when there is really long title text - in this case, the right side of the outline is completely hidden |
Description
focus:visible
outline ofsite-title
not visible #2696Examples in Firefox, Safari, and Chrome respectively (macOS):