Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add node v16 & update Github actions #539

Merged
merged 6 commits into from
Feb 13, 2023
Merged

build: add node v16 & update Github actions #539

merged 6 commits into from
Feb 13, 2023

Conversation

amareshsm
Copy link
Contributor

@amareshsm amareshsm commented Nov 19, 2022 •
edited by valscion
Loading

Description

  1. Add node v16 to workflow.
  2. update Github actions to v3.

@valscion
Copy link
Member

Can we keep the existing Node.js version 10 tests as they were?

@valscion
Copy link
Member

Hi @amareshsm are you still working on this PR or is it stale?

@amareshsm amareshsm changed the title build: add node v16, 18, 19 & update Github actions build: add node v16, 18 & update Github actions Jan 10, 2023
@amareshsm
Copy link
Contributor Author

Can we keep the existing Node.js version 10 tests as they were?

done. pls, approve the workflow.

@valscion
Copy link
Member

Thanks, I did that! I'll try to remember to check this PR tomorrow when I'm back at the computer ☺️

@valscion
Copy link
Member

Huh, v18.x seems to be failing and I have no clue why:

 [13:47:42] 'compileViewerScripts' errored after 1.63 s
[13:47:42] Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:71:19)
    at Object.createHash (node:crypto:133:10)
    at BulkUpdateDecorator.hashFactory (/home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack/lib/util/createHash.js:144:18)
    at BulkUpdateDecorator.update (/home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack/lib/util/createHash.js:46:50)
    at SourceMapSource.updateHash (/home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack-sources/lib/SourceMapSource.js:233:8)
    at NormalModule._initBuildHash (/home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack/lib/NormalModule.js:867:17)
    at handleParseResult (/home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack/lib/NormalModule.js:933:10)
    at /home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack/lib/NormalModule.js:1025:4
    at processResult (/home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack/lib/NormalModule.js:742:11)
    at /home/runner/work/webpack-bundle-analyzer/webpack-bundle-analyzer/node_modules/webpack/lib/NormalModule.js:806:5
[13:47:42] 'build' errored after 2.74 s
Error: Process completed with exit code 1.

@valscion valscion changed the title build: add node v16, 18 & update Github actions build: add node v16 & update Github actions Feb 13, 2023
valscion
valscion approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@valscion valscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I'll merge this now.

I want to get the Node.js v16.x and the other changes in as they work, so I dropped the addition of Node.js v18.x now.

If you can take a look at figuring out why the tests fail with Node.js v18.x, that'd be super!

@valscion valscion merged commit 3a6e20a into webpack-contrib:master Feb 13, 2023
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Feb 14, 2023
Update dependency webpack-bundle-analyzer to v4.8.0 (#1783)
88e0faa 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [webpack-bundle-analyzer](https://github.com/webpack-contrib/webpack-bundle-analyzer) | devDependencies | minor | [`4.7.0` -> `4.8.0`](https://renovatebot.com/diffs/npm/webpack-bundle-analyzer/4.7.0/4.8.0) |

---

### Release Notes

<details>
<summary>webpack-contrib/webpack-bundle-analyzer</summary>

### [`v4.8.0`](https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/HEAD/CHANGELOG.md#&#8203;480)

[Compare Source](webpack-contrib/webpack-bundle-analyzer@v4.7.0...v4.8.0)

-   **Improvement**
    -   Support reading large (>500MB) stats.json files ([#&#8203;423](webpack-contrib/webpack-bundle-analyzer#423) by [@&#8203;henry-alakazhang](https://github.com/henry-alakazhang))
    -   Improve search UX by graying out non-matches ([#&#8203;554](webpack-contrib/webpack-bundle-analyzer#554) by [@&#8203;starpit](https://github.com/starpit))

-   **Internal**
    -   Add Node.js v16.x to CI and update GitHub actions ([#&#8203;539](webpack-contrib/webpack-bundle-analyzer#539) by [@&#8203;amareshsm](https://github.com/amareshsm))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [x] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMzMuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEzMy4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1783
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valscion valscion valscion approved these changes

Assignees
No one assigned
Labels
type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amareshsm @valscion