Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webdriverio): new features for url command #13222

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

christian-bromann
Copy link
Member

Proposed changes

This patch proposes several improvements for the url command, mainly:

  • make the url command return an object with information about the request (and all subrequests) with informations about header, cookies, mime types etc.
  • allow to set a wait state that can be either of the following:
    • none: no wait after the page request is made and the response is received
    • interactive: wait until the page is interactive
    • complete: wait until the DOM tree of the page is fully loaded
    • networkIdle: wait until there are no pending network requests
  • allow to modify headers and/or set auth credentials to overcome page requests that require basic auth

Types of changes

  • Polish (an improvement for an existing feature)
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (improvements to the project's docs)
  • Specification changes (updates to WebDriver command specifications)
  • Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

  • This change is solely for v9 and doesn't need to be back-ported
  • Back-ported PR at #XXXXX

Further comments

n/a

Reviewers: @webdriverio/project-committers

@christian-bromann christian-bromann added the PR: New Feature 🚀 PRs that contain new features label Jul 29, 2024
@christian-bromann christian-bromann merged commit dd15143 into main Jul 30, 2024
44 checks passed
@christian-bromann christian-bromann deleted the cb/url-command-improvements branch July 30, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: New Feature 🚀 PRs that contain new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant