feat: support watch rslib.config to rebuild
#489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #489 will degrade performances by 38.82%Comparing Summary
Benchmarks breakdown
|
chenjiahan
reviewed
Nov 29, 2024
| @@ -0,0 +1,76 @@ | |||
| import path from 'node:path'; | |||
| import chokidar from 'chokidar'; | |||
chenjiahan
reviewed
Nov 29, 2024
| ignoreInitial: true, | ||
| // If watching fails due to read permissions, the errors will be suppressed silently. | ||
| ignorePermissionErrors: true, | ||
| ignored: ['**/node_modules/**', '**/.git/**', '**/.DS_Store/**'], |
There was a problem hiding this comment.
chokidar v4 does not support glob, this will not work
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Links
closes: #138
Checklist