Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTreeView): independent selection drops async children #13950

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

David-Crty
Copy link
Contributor

@David-Crty David-Crty commented Jul 20, 2021

From #11015

When using selection-type="independant" and loading async children the current value of the v-model is resset.

Description

Adding a check if current selection type is independant.
Resolves & inspired by #11015
Should also fix #8791

Motivation and Context

How Has This Been Tested?

No tests added, I have tested this on my local dev and everything looks good, don't know if I should do more ?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

David-Crty added a commit to David-Crty/vuetify that referenced this pull request Jul 20, 2021
@David-Crty David-Crty changed the title fix(VTreeView)Type independent selection drops on async children fix(VTreeView) Type independent selection drops on async children Jul 20, 2021
@johnleider johnleider requested a review from nekosaur July 28, 2021 23:27
@johnleider johnleider added C: VTreeview T: bug Functionality that does not work as intended/expected labels Jul 28, 2021
@johnleider johnleider added this to the v2.5.x milestone Jul 28, 2021
@johnleider
Copy link
Member

@nekosaur can you review this?

@KaelWD KaelWD changed the title fix(VTreeView) Type independent selection drops on async children fix(VTreeView): independent selection drops async children Oct 10, 2021
@KaelWD KaelWD merged commit 71d6bde into vuetifyjs:master Oct 10, 2021
mcdmaster pushed a commit to mcdmaster/vuetify that referenced this pull request Oct 25, 2021
@David-Crty David-Crty deleted the patch-1 branch November 6, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTreeview T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VTreeview - selection-type="independent" + dynamically loaded children incompatibility
3 participants