-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coverage): fix bundling of v8-to-istanbul
#5549
fix(coverage): fix bundling of v8-to-istanbul
#5549
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Regarding this comment #5532 (comment)
This is working fine in Vitest's monorepo and in ecosystem-ci projects.
I think, for the tests inside this repo, Vitest (vite-node) see @vitest/coverage-v8
as non external, so it's probably injecting cjs compat including require
:
vitest/packages/vite-node/src/client.ts
Lines 392 to 393 in c84113f
// cjs compact | |
require: createRequire(href), |
I thought ecosystem-ci would catch this, but maybe we don't test @vitest/coverage-v8
? It looks like the one in coverage-large
is using only istanbul https://github.com/vitest-tests/coverage-large/blob/6dc5a055b30556e78ee3a0b6fff3968fac222c07/vitest.config.ts#L29
Looks like |
When can we expect a release with a fix? |
Description
Looks like Rollup doesn't transpile
require('fs').promises
.Changes in bundle:
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.