Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request_ignorer.rb to add host.docker.internal as a LOCALHOST_ALIAS #1016

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

jamesmcguirepro
Copy link
Contributor

@jamesmcguirepro jamesmcguirepro commented Mar 22, 2024

What's changing?

Testing notes

  • Confirmed unit test coverage here
  • Ran tests locally:
jamesmcguire@MAC-2FHKQ7X vcr % be rake
/Users/jamesmcguire/.asdf/installs/ruby/3.0.6/bin/ruby -I/Users/jamesmcguire/.asdf/installs/ruby/3.0.6/lib/ruby/gems/3.0.0/gems/rspec-core-3.13.0/lib:/Users/jamesmcguire/.asdf/installs/ruby/3.0.6/lib/ruby/gems/3.0.0/gems/rspec-support-3.13.1/lib /Users/jamesmcguire/.asdf/installs/ruby/3.0.6/lib/ruby/gems/3.0.0/gems/rspec-core-3.13.0/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
Run options: include {:focus=>true}

All examples were filtered out; ignoring {:focus=>true}

Randomized with seed 63491
......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................*................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

Pending: (Failures listed here are expected and do not affect your suite's status)

  1) VCR when used in a multithreaded environment with an around_http_request can use a cassette in an #around_http_request hook
     # This is currently very flaky...but definitely worth investigating at some point
     # ./spec/acceptance/concurrency_spec.rb:15


Finished in 16.2 seconds (files took 2.62 seconds to load)
1991 examples, 0 failures, 1 pending

Randomized with seed 63491

Coverage report generated for RSpec to /Users/jamesmcguire/repos/vcr/coverage. 5277 / 5396 LOC (97.79%) covered.
/Users/jamesmcguire/.asdf/installs/ruby/3.0.6/bin/ruby -S bundle exec cucumber
Using the default profile...
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

253 scenarios (253 passed)
1228 steps (1228 passed)
4m23.885s
┌──────────────────────────────────────────────────────────────────────────────┐
│ Share your Cucumber Report with your team at https://reports.cucumber.io     │
│                                                                              │
│ Command line option:    --publish                                            │
│ Environment variable:   CUCUMBER_PUBLISH_ENABLED=true                        │
│ cucumber.yml:           default: --publish                                   │
│                                                                              │
│ More information at https://cucumber.io/docs/cucumber/environment-variables/ │
│                                                                              │
│ To disable this message, specify CUCUMBER_PUBLISH_QUIET=true or use the      │
│ --publish-quiet option. You can also add this to your cucumber.yml:          │
│ default: --publish-quiet                                                     │
└──────────────────────────────────────────────────────────────────────────────┘
jamesmcguire@MAC-2FHKQ7X vcr %

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable!

@olleolleolle olleolleolle merged commit cde8934 into vcr:master Mar 23, 2024
9 checks passed
@jamesmcguirepro jamesmcguirepro deleted the patch-1 branch December 16, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants