Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move require "faraday/multipart" to spec/ where it is being used #1032

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Move require "faraday/multipart" to spec/ where it is being used #1032

merged 1 commit into from
Aug 20, 2024

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Aug 20, 2024 •
edited
Loading

This PR moves a require statement to a test file, out of the implementation file. This makes the library required a test dependency only, avoiding users having to change their Gemfile.

Try to fix #1031

@olleolleolle olleolleolle changed the title Move require to spec/ Move require "faraday/multipart" to spec/ where it is being used Aug 20, 2024
@olleolleolle olleolleolle marked this pull request as ready for review August 20, 2024 08:55
@colinbruce colinbruce mentioned this pull request Aug 20, 2024
Closed
@olleolleolle olleolleolle merged commit 601900d into master Aug 20, 2024
41 checks passed
@olleolleolle olleolleolle deleted the try-to-avoid-require branch August 20, 2024 08:59
@andrehjr
Copy link
Contributor

Thanks for the quick fix @olleolleolle 🙌 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in VCR 6.3.0: cannot load such file -- faraday/multipart
2 participants
@olleolleolle @andrehjr