add error message when cassete file does not exist #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulovilarinho-shopify
force-pushed
the
add-error-message-when-cassete-file-does-not-exist
branch
5 times, most recently
from
84655c8 to
0bb4a9a
Compare
olleolleolle
reviewed
Aug 2, 2024
There was a problem hiding this comment.
Thank you, @PauloVilarinho, I added some suggestions, this looks like we can get it in next week!
paulovilarinho-shopify
force-pushed
the
add-error-message-when-cassete-file-does-not-exist
branch
from
0bb4a9a to
3c909a6
Compare
|
All changes applied @olleolleolle, thanks for the feedback! |
paulovilarinho-shopify
force-pushed
the
add-error-message-when-cassete-file-does-not-exist
branch
from
3c909a6 to
84a71bc
Compare
andrehjr
reviewed
Aug 3, 2024
olleolleolle
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #985
Adds error message to when cassete is using record mode :none but file is not found