Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin CFFI to a new release candidate instead of a Git commit #3398

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Pin CFFI to a new release candidate instead of a Git commit #3398

merged 2 commits into from
Jun 17, 2024

Conversation

illia-v
Copy link
Member

@illia-v illia-v commented May 27, 2024

No description provided.

@illia-v illia-v added the Skip Changelog Pull requests that don't require a changelog entry label May 27, 2024
@illia-v illia-v requested a review from pquentin June 16, 2024 20:07
pquentin
pquentin approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for cleaning this up! And sorry for missing it. LGTM.

@illia-v illia-v merged commit 34be4a5 into urllib3:main Jun 17, 2024
34 of 36 checks passed
@illia-v illia-v deleted the cffi-1.17.0rc1 branch June 17, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

Assignees
No one assigned
Labels
Skip Changelog Pull requests that don't require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illia-v @pquentin