fix(core): use correct position for getMarksBetween (#5412)

ueberdosis · Aug 5, 2024 · efb27fa · efb27fa
1 parent e143fb4
commit efb27fa
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/real-kiwis-double.md b/.changeset/real-kiwis-double.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/core": patch
+---
+
+This fixes a discrepency between `getMarksBetween` and `isActive(markName)` where the position used for getMarksBetween was off by one
diff --git a/packages/core/src/helpers/getMarksBetween.ts b/packages/core/src/helpers/getMarksBetween.ts
@@ -12,7 +12,7 @@ export function getMarksBetween(from: number, to: number, doc: ProseMirrorNode):
       .resolve(from)
       .marks()
       .forEach(mark => {
-        const $pos = doc.resolve(from - 1)
+        const $pos = doc.resolve(from)
         const range = getMarkRange($pos, mark.type)
 
         if (!range) {