fix(core): check schema's nesting rules on contentCheck (#5500) (#5535)

ueberdosis · Aug 21, 2024 · 8d8d999 · 8d8d999
1 parent f8d79da
commit 8d8d999
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 1 deletion.
diff --git a/.changeset/mean-pets-unite.md b/.changeset/mean-pets-unite.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/core": patch
+---
+
+fix: check for schema's nesting rules on contentCheck
diff --git a/packages/core/src/helpers/createNodeFromContent.ts b/packages/core/src/helpers/createNodeFromContent.ts
@@ -45,7 +45,13 @@ export function createNodeFromContent(
         return Fragment.fromArray(content.map(item => schema.nodeFromJSON(item)))
       }
 
-      return schema.nodeFromJSON(content)
+      const node = schema.nodeFromJSON(content)
+
+      if (options.errorOnInvalidContent) {
+        node.check()
+      }
+
+      return node
     } catch (error) {
       if (options.errorOnInvalidContent) {
         throw new Error('[tiptap error]: Invalid JSON content', { cause: error as Error })

diff --git a/tests/cypress/integration/core/createNodeFromContent.spec.ts b/tests/cypress/integration/core/createNodeFromContent.spec.ts
@@ -242,4 +242,25 @@ describe('createNodeFromContent', () => {
       ]), { errorOnInvalidContent: true })
     }).to.throw('[tiptap error]: Invalid JSON content')
   })
+
+  it('if `errorOnInvalidContent` is true, will throw an error, when the JSON content does not follow the nesting rules of the schema', () => {
+    const content = {
+      type: 'paragraph',
+      content: [{
+        type: 'paragraph',
+        content: [{
+          type: 'text',
+          text: 'Example Text',
+        }],
+      }],
+    }
+
+    expect(() => {
+      createNodeFromContent(content, getSchemaByResolvedExtensions([
+        Document,
+        Paragraph,
+        Text,
+      ]), { errorOnInvalidContent: true })
+    }).to.throw('[tiptap error]: Invalid JSON content')
+  })
 })