fix(core): account for node attrs when checking if content is equal

ueberdosis · Jul 22, 2024 · 35682d1 · 35682d1
1 parent 4e5b2d8
commit 35682d1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/lovely-cougars-care.md b/.changeset/lovely-cougars-care.md
@@ -0,0 +1,5 @@
+---
+"@tiptap/core": patch
+---
+
+This fixes a bug with the placeholder extension where a heading level other than the default was not considered empty, when comparing node contents, we need to consider that the node attributes are carried over for a fair comparison of content instead of attribute values
diff --git a/packages/core/src/helpers/isNodeEmpty.ts b/packages/core/src/helpers/isNodeEmpty.ts
@@ -1,7 +1,7 @@
 import { Node as ProseMirrorNode } from '@tiptap/pm/model'
 
 export function isNodeEmpty(node: ProseMirrorNode): boolean {
-  const defaultContent = node.type.createAndFill()
+  const defaultContent = node.type.createAndFill(node.attrs)
 
   if (!defaultContent) {
     return false