feat: new no-unnecessary-act rule
#365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
force-pushed
the
259_no-unnecessary-act
branch
from
5c4bb45 to
a7996e6
Compare
isNodeComingFromTestingLibrary wasn't checking if the imported declaration name matches some Testing Library valid module
Belco90
force-pushed
the
259_no-unnecessary-act
branch
from
44a7d6a to
489be04
Compare
Belco90
commented
May 4, 2021
| } | ||
| ); | ||
|
|
||
| const isReactDomTestUtilsAct = (() => { |
There was a problem hiding this comment.
I know there are several IIFE used here and some blocks could be refactored or extracted. I'm gonna leave it like this so first I fix the issues found and then, having proper context, I'll refactor and extract corresponding functions.
|
|
kentcdodds
reviewed
May 6, 2021
|
Other than that, this looks great! |
gndelia
reviewed
May 6, 2021
gndelia
reviewed
May 6, 2021
gndelia
reviewed
May 6, 2021
zaicevas
reviewed
May 6, 2021
gndelia
reviewed
May 6, 2021
gndelia
reviewed
May 6, 2021
gndelia
reviewed
May 6, 2021
gndelia
reviewed
May 6, 2021
gndelia
previously approved these changes
May 6, 2021
There was a problem hiding this comment.
This looks great. I left some minor suggestions, but LGTM. Kudos to @alessbell and @Belco90 ! 🚀
Belco90
commented
May 6, 2021
|
🎉 This PR is included in version 4.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #259
Co-authored-by: @alessbell
I've found few issues detecting Testing Library packages during the development of this rule. I've fixed one of them, and I'll pinpoint the rest of them in this very PR so I can fix them separately after this rule gets merged.