Draft: Encode escape for btoa (request help) #1318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was confused about this PR at first (was wondering why escape/unescape was being used) but now I looked through this page I think I get it.
To fix this, I'm taking the hack you're describing and making it secondary to using the native node Buffer (I'm assuming Buffer is faster). // to/from base64 functions
// Prefer built-in Buffer, if available, then use hack
// https://developer.mozilla.org/en-US/docs/Glossary/Base64#The_Unicode_Problem
var to_ascii = typeof Buffer !== "undefined"
? (b64) => Buffer.from(b64, "base64").toString()
: (b64) => decodeURIComponent(escape(atob(b64)));
var to_base64 = typeof Buffer !== "undefined"
? (str) => Buffer.from(str).toString("base64")
: (str) => btoa(unescape(encodeURIComponent(str)));It encodes/decodes base64 in node, bun and deno |
fabiosantoscode
added a commit
that referenced
this pull request
Jan 29, 2023
|
Appreciate you reaching out with the fix! |
|
That's awesome, thanks for looking into this! Do you know roughly when the next tag release will be so we can look at updating it in our tools? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to fix #1018
Due to a bug on our services here: playcanvas/editor#950
By encoding and escaping the string before btoa, we can encode the content correctly and this fixes half the tests.
However, I don't understand enough about the second lot of tests regarding the map names. Can someone help point me how these map names are generated please